wayfair / ospo-automation Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update GitHub Actions (major) (actions/checkout, actions/github-script, actions/stale, suzuki-shunsuke/github-action-renovate-config-validator)

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

• Update suzuki-shunsuke/github-action-renovate-config-validator action to v0.1.3

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

Description

There are several known edge cases and limitations with the current Fork Request PR workflow:

• The workflow cannot currently process more than one user-submitted .yml file in the requests/fork/ directory. This is by design, so that we have a 1:1 audit trail for self-service requests, but we don't currently handle it gracefully or explicitly instruct users to submit one request at a time. In the short term, we can improve error handling and update the README to instruct users to avoid this. In the long term, we should consider the ability to support processing X number of requests (of the same type) in a single PR, but this will require some refactor.
• When two fork requests are made with the same repository name (but a different org/owner), the second request will likely fail due to name collision. This runs counter to how GitHub handles duplicate-name fork requests, which is to auto-increment the subsequent forks by -1, -2, etc.

Expected Behaviour

Fork Request workflow can gracefully handle edge cases, either existing and printing a useful error message for the user, or attempting to parse the user's request where possible.

Actual Behaviour

The workflow fails with unhelpful errors, or does not run at all.

Additional Context

See also: #43

Problem Statement

Now that GitHub natively supports automerge policies on repositories, we should enable this in ospo-automation and update our self-service PR workflow checklist / instructions to inform users on how to enable automerge for their PRs.

Proposed Solution

We can follow the example set in ospo-names for how to accomplish this easily.

Additional Context

See also: #43