wcoder / xamarin.plugin.deviceorientation Goto Github PK

It took me way too long to find out that you need to set this in the Info.plist.

• Android
• iOS
• UWP

In the device compatibility, this is listed: v2.0 updated to NetStandard 2.0, but there is no v2.0 and the Plugin doesn't work with iOS with NetStandard 2.0.

On android with:

String s = CrossDeviceOrientation.Current.CurrentOrientation.ToString();

I get:

System.NullReferenceException: 
Object reference not set to an instance of an object.

Working normally on Windows Phone.

Hi,
I want to prevent the app to be rotated to portrait mode in certain scenarios, but I need it available so I can't disable it completely.
I know we have the OrientationChanged event but it fires after the orientation changes.

In other words; I want the app to be available in landscape and landscape flipped mode.
How can I achieve this?

I'm currently using Xamarin.Forms with PCL.

• Android
• iOS
• UWP

I am testing on a real device and an emulator on android, the library picks up the orientation change ok but the but the orientation detected is opposite of what is expected.
"Plugin.DeviceOrientation" version="1.0.5"

CrossDeviceOrientation.Current.CurrentOrientation is reversed on some Android tablets. I guess this is because some tablets are in landscape mode by default. We could reproduce this with:

• Sony Xperia Tablet Z2 (android 5.1.1)
• Google pixel c (android 8.1.0)
• Google Nexus 10 (android 5.1.1)
• Samsung Galaxy Tab 4

I suspect there are many more devices with this problem. We could't reproduce it with emulators or any smartphone.

activity.Resources.Configuration.Orientation returns Landscape

activity.WindowManager.DefaultDisplay.Rotation returns Rotation180 and is converted by your plugin to DeviceOrientations.PortraitFlipped but this is wrong.

activity.WindowManager.DefaultDisplay is deprecated since API Level 11, this should be replaced with a more recent solution

probably related to #10

Hello, I do this:

        if (Settings.OrientationSwitch)
        {
            DeviceOrientations selectedOrientation = Settings.Orientation == 0 ? DeviceOrientations.Portrait : DeviceOrientations.Landscape;

            CrossDeviceOrientation.Current.LockOrientation(selectedOrientation);
        }

Is working perfectly on iOS mobile, but is not working when I deploy to tablet devices. Any idea?

Thank you!

lock for landscape first, then unlock,
the screen remains landscape,even if the device is potrait.

Hi, in my app I need to change to PortraitFlipped at one time. But when I try to do this, the app crashes with this error:
Foundation.MonoTouchException: Objective-C exception thrown. Name: UIApplicationInvalidInterfaceOrientation Reason: Supported orientations has no common orientation with the application, and [Xamarin_Forms_Platform_iOS_PlatformRenderer shouldAutorotate] is returning YES

This is my Info.plist:

<key>UISupportedInterfaceOrientations</key>
<array>
	<string>UIInterfaceOrientationPortrait</string>
	<string>UIInterfaceOrientationPortraitUpsideDown</string>
	<string>UIInterfaceOrientationLandscapeLeft</string>
	<string>UIInterfaceOrientationLandscapeRight</string>
</array>
<key>UISupportedInterfaceOrientations~ipad</key>
<array>
	<string>UIInterfaceOrientationPortrait</string>
	<string>UIInterfaceOrientationPortraitUpsideDown</string>
	<string>UIInterfaceOrientationLandscapeLeft</string>
	<string>UIInterfaceOrientationLandscapeRight</string>
</array>

In my AppDelegate I have put this:

[Export("application:supportedInterfaceOrientationsForWindow:")]
public UIInterfaceOrientationMask GetSupportedInterfaceOrientations(UIApplication application, IntPtr forWindow)
{
	return DeviceOrientationImplementation.SupportedInterfaceOrientations;
}

The other orientations are not causing trouble.
I am working with Xamarin.Forms, the device is an iPhone 8 and the crash occurs both on the real device and simulator.

From @avinashramireddy-rapidd #5:

OrientationChanged is hitting many times(lost count-50+ or more I don't know...) while debugging.

Please add support for NETSTANDARD 2.0

How can I set to default the orientation of the App to Landscape? then actually just locking and never allowing the user to put the app into portrait mode?

First of all, thank you @wcoder for this plugin. It's great and really does the job for us 👍

-- The issue --
We get this build warning. Thank you for updating the code accordingly or please let me know if this is a configuration issue I can fix on my end.
Warning XA0125: 'Plugin.DeviceOrientation.pdb' is using a deprecated debug information level.

What is the correct way to do orientation comparisons? I've tried the following, none of which work:

bool fail1 = CrossDeviceOrientation.Current == 2;
bool fail2 = CrossDeviceOrientation.Current == DeviceOrientations.Portrait;
bool fail3 = CrossDeviceOrientation.Current.Equals(DeviceOrientations.Portrait);

Coming from Swift/Obj-C, I'm sure there is some dumb thing I am doing here. Also, would be great if you included an example like this in the docs.

When using the lockorientation to portrait in xamarin forms even then the screen is rotating to the landscape mode.

Im trying to force an orientation for one view on ios, and thought I could use "LockOrientation" for this, but does not seem to work. Am I doing something wrong or is it not supported?

Minimal solution here: (I would think page should rotate on clicked "Rotate page")

https://github.com/tompi/DebugXamarinForceOrientation

Hope you have time to take a quick look!

I am using this plugin in my xamarin forms app. But when I want to change the orientation to Landscape app getting crash and giving me a NullReferenceException in Android.

Android version 9(Pie)
Xamarin.Forms version is 4.2.0.848062

Tried to use the nuget package without success, so I cloned the repo and started the sample app on an ipad with ios 11.3.1.

Screen rotates even if label says locked...

This is the case for both the samples-solution and the TestNugetDeviceOrientationPlugin

DeviceOrientationImplementation.set_IsListenerEnabled (System.Boolean value)
System.ObjectDisposedException: Cannot access a disposed object. Object name: 'Plugin.DeviceOrientation.OrientationListener'.

This is thrown when the following override in the MainActivity is called after switching away from app and then back to app:
public override void OnConfigurationChanged(Android.Content.Res.Configuration newConfig)
{
DeviceOrientationImplementation.NotifyOrientationChange(newConfig.Orientation);
}

Repo steps:
Tested on Android v8 and v9

• Implement override so that NotifyOrientationChange is called in Android
• Open app and use so the LockOrientation is called
• Put app in background
• Put app back in foreground
• When changing the orientation, the app will crash because the OrientationListener is disposed.

Currently, Xamarin.Plugin.DeviceOrientation uses the Plugin.CurrentActivity nuget package in the Android implementation to access the current activity. This is the same behavior as many plugins use. However, since the rise of Xamarin.Essentials (which also offers access to Android's current activity), I would propose to eliminate the direct dependency to Plugin.CurrentActivity. Instead, I'd add a new static method to CrossDeviceOrientation: SetCurrentActivityResolver(Func activityResolver) which dynamically resolves the current activity from either Plugin.CurrentActivity or Xamarin.Essentials (or another plugin).

A similar solution is successfully used in the Fingerprint plugin (https://github.com/smstuebe/xamarin-fingerprint). Check the following CrossFingerprint.Android.cs file:
https://github.com/smstuebe/xamarin-fingerprint/blob/9fb42c4a8b620260c0c03eb2714e2e03a92d472b/src/Plugin.Fingerprint/Platforms/Android/CrossFingerprint.Android.cs

What do you think of this proposal for extension?

On iOS, everything is perfectly fine, but as soon as I use this on Android, everything is switched around? When I rotate the device and print out the orientation, it says it is Landscape, when it is actually Portrait?

Here is my custom Image class where the error exists:

using Plugin.DeviceOrientation;
using Plugin.DeviceOrientation.Abstractions;
using System;
using System.Collections.Generic;
using System.Text;
using Xamarin.Forms;

namespace Project.Custom
{
    public class DSImage : Image
    {
        public DSImage(int phonePortrait, int phoneLandscape, int tabletPortrait, int tabletLandscape)
        {
            if (Device.Idiom == TargetIdiom.Phone)
            {
                if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Portrait || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.PortraitFlipped)
                {
                    System.Diagnostics.Debug.WriteLine("Phone Portrait");
                    HeightRequest = phonePortrait;
                }
                else if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Landscape || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.LandscapeFlipped)
                {
                    System.Diagnostics.Debug.WriteLine("Phone Landscape");
                    HeightRequest = phoneLandscape;
                }
            }
            else if (Device.Idiom == TargetIdiom.Tablet)
            {
                if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Portrait || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.PortraitFlipped)
                {
                    System.Diagnostics.Debug.WriteLine("Tablet Portrait");
                    HeightRequest = tabletPortrait;
                }
                else if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Landscape || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.LandscapeFlipped)
                {
                    System.Diagnostics.Debug.WriteLine("Tablet Landscape");
                    HeightRequest = tabletLandscape;
                }
            }

            CrossDeviceOrientation.Current.OrientationChanged += (sender, args) =>
            {
                if (Device.Idiom == TargetIdiom.Phone)
                {
                    if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Portrait || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.PortraitFlipped)
                    {
                        System.Diagnostics.Debug.WriteLine("Phone Portrait");
                        HeightRequest = phonePortrait;
                    }
                    else if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Landscape || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.LandscapeFlipped)
                    {
                        System.Diagnostics.Debug.WriteLine("Phone Landscape");
                        HeightRequest = phoneLandscape;
                    }
                }
                else if (Device.Idiom == TargetIdiom.Tablet)
                {
                    if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Portrait || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.PortraitFlipped)
                    {
                        System.Diagnostics.Debug.WriteLine("Tablet Portrait");
                        HeightRequest = tabletPortrait;
                    }
                    else if (CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.Landscape || CrossDeviceOrientation.Current.CurrentOrientation == DeviceOrientations.LandscapeFlipped)
                    {
                        System.Diagnostics.Debug.WriteLine("Tablet Landscape");
                        HeightRequest = tabletLandscape;
                    }
                }
            };
        }
    }
}