wcout / fltk-gif-animation Goto Github PK

Still finding this code to be extremely useful.

I've used the patch which changes fl_images_core.cxx, in fl_check_images, so that GIF files are loaded as Fl_Anim_GIF_Image instances.

But this leads to the following convolution when it comes time to draw, in order to handle non-animated GIFs:

		if (animgif_->is_animated())
		{
			animgif_->draw(xoff, yoff, xsize, ysize);
		}
		else
		{
			animgif_->Fl_Pixmap::draw(xoff, yoff, xsize, ysize);
		}

It "works" but requires "knowing" that Fl_Anim_GIF_Image is derived from Fl_Pixmap!

I'd prefer that animgif_->draw() would work for both animated and still GIFs. I'm not smart enough yet to quite understand the implications of this comment in the Fl_Anim_GIF_Image code:

    // Note: should the base class be called here?
    //       If it is, then the copy() method must also
    //       copy the base image!
//    Inherited::draw(x_, y_, w_, h_, cx_, cy_);

Advice, fixes appreciated.

.. because it erroneously always copies with size of whole canvas size instead only the with size/offset of the previous frame.

Just getting started but so far this project is looking fantastic!!

A blocker for Windows users: in Fl_Anim_GIF_Image.cxx, in the function readin, the following line (at or about line 548):

  FILE *gif = fopen(name_, "r");

needs to be changed to:

  FILE *gif = fopen(name_, "rb");

Without the binary flag, Windows will stop reading at the first zero byte.

As alluded to in issue #2, the attached animated GIF image cannot be loaded by Fl_Anim_GIF_Image.

0_bfKvMYVWUpbBtXM5.zip