Giter VIP home page Giter VIP logo

ring-mock's Issues

Convert project license to MIT for consistency with other Ring projects

I'd like to make Ring-Mock an official Ring library, but for consistency's sake I'd like to change Ring-Mock's license from EPL to MIT.

@aredington, @neatonk, @timewald, @glenjamin and @senior, could I get each of your permissions to release your additions to Ring Mock under the MIT license?

(I was originally intending to coordinate this via email, but not everyone involved has a public email, so my apologies for the duplication, @senior.)

maybe wrong behaviour on params' request parameter

here http://weavejester.github.io/ring-mock/ring.mock.request.html#var-request it says

Create a minimal valid request map from a HTTP method keyword, a string
containing a URI, and an optional map of parameters that will be added to
the query string of the URI. The URI can be relative or absolute. Relative
URIs are assumed to go to http://localhost.

but

user=> (:query-string (req/request :delete "/foo" {:id 4}))
nil

user=> (slurp (:body (req/request :delete "/foo" {:id 4})))
"id=4"

with this it works

user=> (:query-string (req/query-string (req/request :delete "/foo" {:id 4}) {:id 4}))
"id=4"

is the doc wrong, the code wrong or am I wrong? :)

Reflection warning in ring/mock/request.clj

Running tests with *warn-on-reflection* generates a warning:

Reflection warning, ring/mock/request.clj:63:17 - reference to field getBytes can't be resolved.

ring-mock version is 0.1.5

Thanks!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.