Giter VIP home page Giter VIP logo

Comments (12)

murillodigital avatar murillodigital commented on May 23, 2024 2

@RandomFractals @usernamehw the development cluster is NOT an AKS cluster, however, since it already has Flux installed, you will not be able to satisfy the condition of the cluster being without it. I'm going to spin a second cluster without Flux, so that you can develop this ticket. We do not want to mess with the flux install on the current cluster cause that would break all the resources already in there. Will provide cluster access details over Slack. The idea here is for flux install to be executed by the Extension, and then you can manually flux uninstall from the terminal, making sure you are talking to the right cluster.

from vscode-gitops-tools.

usernamehw avatar usernamehw commented on May 23, 2024 1

Running flux install...

from vscode-gitops-tools.

usernamehw avatar usernamehw commented on May 23, 2024 1

They do go away.

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

@murillodigital to set up new cluster for us to test this.

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

@usernamehw please test the config Leo shared in slack once you get flux system nodes and controllers loading done in #36

We should be able to run those flux install/uninstall commands and refresh our Clusters tree view to see extra flux sytem info loaded there.

We'll add the Enable GitOps menu option and command once we can confirm the above manual approach works.

from vscode-gitops-tools.

usernamehw avatar usernamehw commented on May 23, 2024

@RandomFractals I know that vscode supports passing objects/arrays for setting complex contexts with setContext, but tree view items can only have 1 string context.

Should we use a regex match in package.json and a string context of the type:
|cluster| or |cluster|clusterFluxEnabled| depending on the state
or until we hit the need for 3 contexts on 1 item we can use:
cluster or clusterFluxEnabled depending on the state.

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

@usernamehw I think we should set cluster node contextValue to fluxCluster when we detect that flux-system namespace from #36 is present and we load those flux controllers.

Then we can simply enable GitOps: Uninstall Flux command for the fluxCluster and enable GitOps: Install Flux command for a regular cluster without flux controllers.

Have you tested the provided cluster without flux as I suggested above?

and do you see flux controllers loaded with that new cluster config when you run flux install and refresh our Clusters tree view?

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

That looks good. Do you see them go away after you run flux uninstall and refresh the Clusters view?

You can wire those commands if that checks out.

from vscode-gitops-tools.

josefaworks avatar josefaworks commented on May 23, 2024

Make sure ticket #71 is addressed as part of this ticket before closing

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

@josefaworks This was created originally to enable GitOps on clusters.

We can use #71 to complete the clulsters view refresh story.

@usernamehw please wire enable gitops menu and commands to the tree view first as I described above.

We'll have to handle tree view updates and cluster node status/indicator updates in other places.

from vscode-gitops-tools.

usernamehw avatar usernamehw commented on May 23, 2024

Not wired to the terminal yet (needs manual refresh), but commands are in place:

Animation

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 23, 2024

this looks good. we'll handle clusters tree view refresh in #71.

from vscode-gitops-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.