Giter VIP home page Giter VIP logo

Comments (8)

RandomFractals avatar RandomFractals commented on May 26, 2024

@murillodigital I see you added more info to this ticket. Should we close #17?

or do you think we still need to discuss providing Enable GitOps menu option?

from vscode-gitops-tools.

murillodigital avatar murillodigital commented on May 26, 2024

@murillodigital I see you added more info to this ticket. Should we close #17?

or do you think we still need to discuss providing Enable GitOps menu option?

I will provide detail on enabling GitOps in a cluster, which actually will be more than one ticket considering the various paths that could take. In our dev cluster, Flux is already installed - this ticket should also handle the display of Flux was not detected in the cluster for those scenarios. Let me know if that clarifies.

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

@murillodigital please provide text tree example of what the above flux check command run should display in our Clusters tree view as child nodes under the sample cluster we are using for testing.

The text code examples you provided above are the results of the command that we will display in Flux terminal output (#48).

The first code sample you provided lists controllers. Do you see Flux as one of the cluster/node components of the cluster? or should that be part of the cluster/node properties view?

Just a reminder this is what our Clusters display now (from #10):

gitops-cluster-list

I believe we need to finalize that tree structure similar to what needs to be done for Deployments in #44

This is what I see for namespaces in k8s tools explorer now. That view lists flux-system. Should our Cluster view have the same nodes in our tree, and then list all the controllers under it?

image

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

k8s tools nodes display for reference:

image

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

per our sprint 3 features discussion with @murillodigital each flux enabled cluster should show these controllers child nodes for now:

  helm-controller (version, status)
  image-automation-controller (version, status)
  image-reflector-controller (version, status)
  kustomize-controller (version, status)
  notification-controller (version, status)
  source-controller (version, status)

He doesn't want us to do anything for the Nodes k8s tools explorer displays in this sprint.

@usernamehw see if you can get the list of those nodes and flux system config via kubectl first. I think we'll default to using that k8s tools api and kubectl cli integration when possible before we integrate flux specific commands to keep our gitops extension generic and working with most kubernetes cluster configurations.

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

@murillodigital ok. after some minor refactors of that PR, this is what we show for the flux-system deployments in the Clusters tree view:

gitops-flux-deployments

I think that cluster should list namespaces, flux-system is one of them, and then we should list those controllers under flux-system node which are actually k8s deployments as you see in the editor config.

Now, I find it confusing to see that and separate Deploymets view. Just not very logical or structured in the way k8s clusters are configured with namespaces and deployments, even if we don't include others and just stick with flux k8s object types

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

latest cluster view with flux controllers and versions info:

gitops-flux-controllers-info

In my opinion, what's missing there is flux-system namespace node that groups those flux controller deployment nodes and shows the info you see in vscode editor pic above.

I'll close this feature ticket as complete for now. It shows if GitOps is enabled and you can also see it in gitops terminal we added in #8 or by running GitOps: Flux Check Prerequisites command I added in #35 any time you want for the currently selected cluster:

gitops-flux-check

from vscode-gitops-tools.

RandomFractals avatar RandomFractals commented on May 26, 2024

@murillodigital I am closing this as I believe the core functionality for this feature request is implemented.

Please file an enhancements request with a reference to this ticket number, if you feel there is more work that needs to be done for this feature.

from vscode-gitops-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.