Add flux.ts pseudo-terminal for integrating Flux CLI commands about vscode-gitops-tools HOT 10 CLOSED

We now have a function to run CLI commands and show its output in the output view:

from vscode-gitops-tools.

Did you wire thsoe command ouputs to our new GitOps progress bar too?

Not yet. Might do that today. If you mean the status bar item.

from vscode-gitops-tools.

@murillodigital here is git commands and output channel sample strictly for illustration purposes. I think our flux CLI integration should function similarly for all the flux commands we execute.

from vscode-gitops-tools.

@murillodigital here is git commands and output channel sample strictly for illustration purposes. I think our flux CLI integration should function similarly for all the flux commands we execute.

@RandomFractals I think this does indeed look good - just to make sure we're on the same page:

• GitOps option in the drop down where Git is selected in the screenshot
• Having that option selected: calls and output generated by the command executions will show in the pseudo-terminal
• stdout and stderr will stream to the pseudo-terminal

Let me know if this is precise. Thanks!

from vscode-gitops-tools.

yeah, actually, those are all custom Output channels. Think of them as a panel for custom logging and diagnostics in vscode.

We'll probably use shelljs just like k8s tools ext. does for running flux commands we need.

I looked at other alternatives and they were either not maintained or with too many issues. Besides, I think it would be best if both of our tools use the same shell lib for running terminal commands.

Anything our flux command runs produce we'll log in that Outputs panel area under GitOps, including error outputs.

from vscode-gitops-tools.

@usernamehw let's add shelljs to our dependencies for this implementation:

https://github.com/shelljs/shelljs

Please bump extension version to 0.5.0 when you update our package.json for new commits that will go into sprint 5.

Also, please review these notes on shell integration: #8 (comment)

We already have custom output channel I created. You just need to wire it on activation and use it for the new flux shell command outputs:

https://github.com/weaveworks/vscode-gitops-tools/blob/main/src/output.ts

from vscode-gitops-tools.

that looks awesome! I just need to check your last commit and review this implementation.

We should show command that produced the output with > like git does, and other such extensions.

Did you wire thsoe command ouputs to our new GitOps progress bar too?

from vscode-gitops-tools.

Not sure if we should put all commands into output. They will be executed async.

For example, when I used both flux and kubectl versions check at the same time they wrote into output:

Longer/slower commands with be all mixed together.

from vscode-gitops-tools.

that's fine. we want to show the trace of all commands we run for all the CLIs we use to populate those k8s cluster views. Think of it as a diagnostics panel to troubleshoot how things are orchestrated in the cloud.

from vscode-gitops-tools.

I believe this can be closed. If you want to see json output from kubectl commands, I would recommend you create a separate ticket and add dev mode or debug config option to toggle it.

from vscode-gitops-tools.