Giter VIP home page Giter VIP logo

Comments (7)

bebraw avatar bebraw commented on May 28, 2024

πŸ‘

from style-loader.

sokra avatar sokra commented on May 28, 2024

omg... this is pretty weird... :-O

from style-loader.

sokra avatar sokra commented on May 28, 2024

in server/bundle.js you are starting the compiler twice:

  var compiler = webpack(webpackConfig, function () {
    console.log('Project is ready!');
  }); // starts a compilation

  var bundler = new WebpackDevServer(compiler, {
    // ...
  }); // starts watching, which also starts a compilation

to fix it:

  var compiler = webpack(webpackConfig); // only create a compiler

  var bundler = new WebpackDevServer(compiler, {
    // ...
  }); // starts watching, which starts the compilation

from style-loader.

sokra avatar sokra commented on May 28, 2024

I propably need to throw an error in this case.

from style-loader.

christianalfoni avatar christianalfoni commented on May 28, 2024

Hehe, thanks for taking a look @sokra and yeah and error there would be good. Though I think a more common pattern using the webpack instance would be:

  var compile = webpack(webpackConfig);
  compile(function () {
   console.log('compiled');
  });

And:

  var compile = webpack(webpackConfig);
  var bundler = new WebpackDevServer(compile, {

  });
  // First compile running

But I suppose that is too big of a change, and maybe does not make sense related to the rest of the API. But I do seem to loose a hook to check when the initial bundle is ready? Maybe add a callback to the webpack dev server?

  var compiler = webpack(webpackConfig);
  var bundler = new WebpackDevServer(compiler, {}, function () {
    // Initial compile done
  });
  // Starts compilation

from style-loader.

christianalfoni avatar christianalfoni commented on May 28, 2024

Ah, I can see there is a plugin mechanism?

  var compiler = webpack(webpackConfig);
  compiler.plugin('done', function () {
    console.log('Compile done');
  });
  var bundler = new WebpackDevServer(compiler, {});
  // Starts compilation

No problems using that?

from style-loader.

SpaceK33z avatar SpaceK33z commented on May 28, 2024

Closing since it looks like it's been fixed.

from style-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.