webrtc-rs / ice Goto Github PK

In order to test NAT, VNet is required for ICE.

Just FYI, there is https://github.com/ystreet/librice library, which also aims to implement ICE in Rust, maybe there is a potential for collaboration here.

I've made some changes to the UDPMuxDefault (link) and had to copy UDPMuxConn, UDPMuxConnParams and socket_addr_ext.rs as well.

Would you agree to expose UDPMuxConn and UDPMuxConnParams so that people can tweak UDPMuxDefault (read create alternative UDP muxes) ? Thanks 🙏

I'd like to use this crate to establish a peer-to-peer connection between clients, but after that I'd like to obtain the underlying (udp) connection.

Without async closure support in those callbacks, it may cause many use-cases unfriendly.

pub type OnConnectionStateChangeHdlrFn = Box<dyn FnMut(ConnectionState) + Send + Sync>;
pub type OnSelectedCandidatePairChangeHdlrFn =
Box<dyn FnMut(&(dyn Candidate + Send + Sync), &(dyn Candidate + Send + Sync)) + Send + Sync>;
pub type OnCandidateHdlrFn = Box<dyn FnMut(Option<Arc<dyn Candidate + Send + Sync>>) + Send + Sync>;

Hey! I'm just browsing the ping_pong example here, and noticed something strange: The request to /remoteCandidate has a content-type of application/json but the data being sent is not JSON. I'm not sure what format it is meant to be or else I'd be doing a PR instead, but regardless this seems wrong as the format is not JSON-based.

I believe that the ICE agent is performing connectivity checks even though I've set the lite flag to true in the AgentConfig used to create it. If I understand it correctly, ice-lite agents don't generate connectivity checks: https://datatracker.ietf.org/doc/html/rfc8445#section-2.5

Having a lite agent not generate connectivity checks is useful when using unsignalled WebRTC connections, because then one agent doesn't need to know the ICE password (or potentially even the username) of the peer that is connecting to it.

I tried to make a minimal example: https://github.com/evan-brass/webrtc-rs-ice-bug/blob/master/src/main.rs

Which gave me a network trace like this:

The second Binding request is from Peer1 (the lite-client) to Peer2 (the full client).

I'm still not-very familiar with the webrtc-ice library's code, but I believe that perhaps a check is needed within the ControlledSelector implementation for AgentInternal?:

I'm still new to ICE and the protocol level of WebRTC so if I'm misunderstanding the protocol, just let me know.

Thank you,