wengkit1 / pe Goto Github PK

Bug Title: Error message for editing name does not match the error

Description

When I try to edit a name field of a patient, the error indicates that the command is invalid. But the error message is unclear.

Steps to Reproduce

1. Open the app
2. Attempt to edit a name 'edit 6 n/a'
3. Observe error message.

Expected behavior

The message should explain that editing of a name is disallowed due to previous issues mentioned. But instead it explains that the command format is invalid. when editing a field of patient seems pretty valid of a format to an average user.

Actual behavior

The message indicates invalid command format.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: Invalid Command format
• Console Errors: None

If the patient is not already in medimeet, the same alt path is also taken.

Bug Title: Unique identity violation.

Description

This is related to a previous issue of unique identification of patients. While the app uses name as a unique identification, it allows for editing of addresses and phone numbers to existing ones on the list.

Steps to Reproduce

1. Open the app
2. Edit fields

Expected behavior

See issue #2. And app should indicate that any phone number/ email already exist on the list.

Actual behavior

App proceeds with edit command and shows success message.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: None
• Console Errors: None

Severity and type

This is not a normal operation of a user, so the severity is low. However, it is a functionality bug as it contradicts the previous behaviour that the developers expect. As duplicate names are not allowed, it is safe to assume that the user should not add the same patient twice on the list. However, two patients can have the same phone numbers and emails, which causes problems in unique identification, as it is unlikely that there are two adults who share the same phone number.

Bug Title: It is not allowed to add patients of the same name under the app

Description

Steps to Reproduce

1. Add a patient using default command example
2. Add patient again changing the email, phone number and address
3. Observe window for error message

Expected behavior

Assuming a doctor uses the app, it is very possible for the clinic to have a lot of patients with the same name.
As such, it should allow adding of such patients into the list.

Actual behavior

The page instead shows an error.

Environment

• Operating System:Mac-OS Ventura
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: This patient already exists in the address book

Priority and type

This bug is listed as a functionality bug as it affects normal operation of the app. Adding a same named patient is very normal operation of a doctor. Priority is medium as this affects normal operation of the app to a certain extent.

Use of square brackets here is confusing, as user may be unclear if that should be part of the command.

Start time before end time predicate missing from sequence.

It should be mentioned in sequence, as the code checks for start time before end time before an appointment is added.

Bug Title: There's an error indication for a valid edit command, when find outputs 0 appointments or patients on the list.

Description

It is unclear that the user has to list, before every edit command. Unclear that the user can only edit command he sees on the window, and not every appointment he has.

Steps to Reproduce

1. Open app
2. Input "find_appt"
3. Use example given
4. Try to edit a previous appointment on the list.

Expected behavior

Clear command flow, for when edit_appt can be used.

Actual behavior

Error indication for edit_appt.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: The appointment index provided is invalid

Bug Title: Patients and appointments are separate entities.

Description

When I attempt to assign a patient to an appointment, there is no such user command.

Steps to Reproduce

1. Open the app
2. Attempt to assign patient to an appointment.

Expected behavior

The patient should be assigned to an appointment with their last four digits nric and phone number for example for unique identification, as a candidate key.

Actual behavior

The patient can be added, and the appointment associated with the patient name can be added.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: None
• Error Messages: None

Severity and type

This is a medium functionality flaw, as the following behaviour causes problems beyond the scope of a feature flaw. The reason is that there are multiple people that may have same names, that go to different appointments. Since the app does not even allow same name individuals to be added, and has no command for assigning individuals to appointments, it is unknown whether the John Doe in appointments list is the same as John Doe in the patients list.

Bug Title: When trying to add an appointment, the instructions are very unclear.

Description

Using the user command stated in help page for add appointment, will indicate that add appointment has a shortcut of 'ap' which is already used for add patient.

Steps to Reproduce

1. Open app
2. Click on help
3. Look at user command instructions for adding appointment.

Expected behavior

The shortcut word for different commands should be different.

Actual behavior

They are the same.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: None
• Console Errors: None

Severity and Type

This can be a functionality bug, as it is unclear if ap is implemented as both add patient and add appointment. However, it is only medium severity, as using the normal command still works, and is not app breaking.

This is a previously mentioned issue refer to issue#4, however I believe it classifies as both types of bug. As UG states a behaviour that is either not in the app or not apparent to the user. ap is used in "add_patient" already.

Bug Title: No error indication for invalid timestamp

Description

There is no error message for invalid timestamp. For example a date that is 01002023.

Steps to Reproduce

1. Open the app.
2. Attempt to add appointment for invalid timestamp.
   3.The window shows no indication of error.

Expected behavior

Error should be indicated.

Actual behavior

There is no error indication, the window shows a previous command message.

Environment

• Operating System: Mac OS Ventura 13.1
• Browser: Google Chrome Version 92.0.4515.159 (Official Build) (64-bit)

Additional Information

• Screenshots: Attached
• Error Messages: None

No details provided by bug reporter.

The has patient predicate should lead to an alt path of patient already in medimeet. Alt path used here does not make it clear what happens if patient is already in predicate.

Similarly in add_appointment.

Since the app requires a lot of adding and deleting names, since edit of names is generally disallowed, editing appointment times is a hassle. An undo feature will greatly enhance use of app, for general mistakes, when performing such add, delete operations for appointments and patients.

UG has lack of visuals for many commands, and possible behaviours. Example: