Add [object] to units on the recall list. (GNA #4450) about wesnoth HOT 7 CLOSED

Modified on 2006-09-25

queenkiller changed category: Bug -> Feature Request

queenkiller changed priority: 5 - Normal -> 3 - Low

queenkiller wrote:

first and second issue is already fixed

Third is feature, so I change it to feature request and low.

from wesnoth.

Modified on 2016-01-11

gfgtdf changed title: Issues with [object], events, recall list and default filter -> Add [object] to units on the recall list.

from wesnoth.

unit:add_modification works for recall list units, so all that would be needed to implement it would be including call to wesnoth.get_recall_units in function wml_actions.object(cfg). Though it would only make sense to do so if user explicitly asks for it with new key to not break anything.

Might make sense to require silent object for recall unit.

from wesnoth.

It might be better to document that [object] doesn't work for recall list units and include a note that [modify_unit] can be used instead (by placing an [object] tag in it that only contains [effect] subtags). I'm not sure if [modify_unit] does currently work for recall list units, though, so that would need to be checked. (Also, [modify_unit] affects all units matching the filter while [object] only takes the first, but if I recall correctly, you can add limit=1 to the filter to get the same effect in [modify_unit].)

Basically my point is the same as @ProditorMagnus's final sentence - most of the [object] tag's ActionWML logic is irrelevant for recall list units.

from wesnoth.

I agree here. Added a note in the wiki, im closing this. If someone has a real usecase in on of his/her addons whre [object] would be suprerior to [modify_unit][object] for recall unit s he can open a new report ( In particular this one is also too hard to read with the outdated information in the first post)

from wesnoth.

@gfgtdf - Did you verify that [modify_unit] works for recall list units?

from wesnoth.

yes (actualyl i had to fix it in master)

from wesnoth.