Comments (8)
See also whatwg/fetch#172
from xhr.
So it seems we need something more complicated since a same-origin to cross-origin redirect as initial response would cause the header to be included, right?
from xhr.
I think so. If we adopt the change, i.e. no Origin header for same-origin, we should align Origin header inclusion yes/no with cross origin yes/no. When we enter cross-origin processing state in response to same to cross redirect, we should include the Origin header in the next, now cross-origin, request.
from xhr.
Maybe HTTP-network-or-cache fetch
should be passed CORS flag
and use it to decide whether or not to append the Origin header.
from xhr.
The problem is that we also use the Origin
header for <form method=POST>
and some other things? What logic does Blink use at the moment?
from xhr.
It's complicated. @hiroshige-g is checking Blink code to sort it out now.
from xhr.
Related gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1272302
from xhr.
FWIW, this is being fixed by whatwg/fetch#225. We're just obsoleting the need for the flag and instead directly check the methods in use (or the CORS flag).
from xhr.
Related Issues (20)
- Expose ProgressEvent to ServiceWorker HOT 14
- Handle error while reading response body in synchronous XHR HOT 1
- Reference primitive for "If one or more event listeners are registered"
- Spec requires firing at least two "progress" events; browsers do not. HOT 1
- features request:add SynXMLHttpRequest for Avoid Callback Hell Programming HOT 1
- Why do we need to remove synchronous XHR? HOT 2
- link error breaking deploys HOT 2
- Allow to send body within GET http requests HOT 1
- Aborted flag check in "handle errors" HOT 2
- interop: blob with empty content type is not converted to text/xml HOT 3
- Wrong upload progress when network interrupts HOT 3
- xmlhttprequest.responseText occasionally appears Chinese garbled characters HOT 1
- XHR: how can I read request headers? HOT 1
- Need Discussion of 'why' Behind Deprecation of sync xhr HOT 2
- Wrong algorithm + missing realm argument when creating ArrayBuffer
- Ambiguous definition/initial values of network error HOT 3
- Use HTML's parse a URL HOT 2
- FormData & submitter[formaction] HOT 6
- `FormData`: Accept `object` form in constructor HOT 1
- Clarify if `ProgressEvent.loaded` should indicate the size of compress, or uncompressed, data HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xhr.