Giter VIP home page Giter VIP logo

Comments (8)

tyoshino avatar tyoshino commented on May 27, 2024

See also whatwg/fetch#172

from xhr.

annevk avatar annevk commented on May 27, 2024

So it seems we need something more complicated since a same-origin to cross-origin redirect as initial response would cause the header to be included, right?

from xhr.

tyoshino avatar tyoshino commented on May 27, 2024

I think so. If we adopt the change, i.e. no Origin header for same-origin, we should align Origin header inclusion yes/no with cross origin yes/no. When we enter cross-origin processing state in response to same to cross redirect, we should include the Origin header in the next, now cross-origin, request.

from xhr.

tyoshino avatar tyoshino commented on May 27, 2024

Maybe HTTP-network-or-cache fetch should be passed CORS flag and use it to decide whether or not to append the Origin header.

from xhr.

annevk avatar annevk commented on May 27, 2024

The problem is that we also use the Origin header for <form method=POST> and some other things? What logic does Blink use at the moment?

from xhr.

tyoshino avatar tyoshino commented on May 27, 2024

It's complicated. @hiroshige-g is checking Blink code to sort it out now.

from xhr.

wanderview avatar wanderview commented on May 27, 2024

Related gecko bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1272302

from xhr.

annevk avatar annevk commented on May 27, 2024

FWIW, this is being fixed by whatwg/fetch#225. We're just obsoleting the need for the flag and instead directly check the methods in use (or the CORS flag).

from xhr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.