Comments (7)
Ah look, we're not alone: signalapp/libsignal-service-java#42
I've taken a precaution in Whisperfish itself, and started licensing that as combined work under AGPLv3+ as of 0.6.0-alpha.1... That shouldn't influence the decision here though.
from libsignal-service-rs.
I think it's reasonable enough to make this project GPLv3/AGPLv3.
Most people would consider this a derived project, seeing as we're using their *.proto
files and using a lot of constructs/concepts from the Java version.
from libsignal-service-rs.
Shouldn't a derived project fall under AGPLv3(+) then, instead of GPLv3/AGPLv3?
from libsignal-service-rs.
Sorry, when I wrote "GPLv3/AGPLv3" I meant "GPLv3 or AGPLv3, whichever is most applicable"... I probably should have been clearer there 😛
That said, the libsignal-service-java
repository as a whole is licensed as GPLv3, so shouldn't we use that? What's the normal course of action when the one of the files your work is derived from has a different license to the rest of the repository?
from libsignal-service-rs.
That said, the
libsignal-service-java
repository as a whole is licensed as GPLv3
I don't think so. Look in the README, all the way down at # License
. In general, the LICENSE file does not necessarily reflect the license for all files in the repo... Should I create an issue back there, for clarification?
Also, if you grep through their repository for "Affero", there are more matches:
rsmet on nas in libsignal-service-java on master [📝] via ☕ v1.8.0
❯ rg Affero Fri 10 Jul 2020 07:54:01 AM UTC
LICENSE
552: 13. Use with the GNU Affero General Public License.
556:under version 3 of the GNU Affero General Public License into a single
559:but the special requirements of the GNU Affero General Public License,
java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License
java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License
java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/DiscoveryRequest.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License
java/src/main/java/org/whispersystems/signalservice/internal/contacts/entities/RemoteAttestationResponse.java
5: * it under the terms of the GNU Affero General Public License as published by
12: * GNU Affero General Public License for more details.
14: * You should have received a copy of the GNU Affero General Public License
I have not used any of the above files. Their README claims however that the whole repo is AGPLv3(+). Maybe this needs some clarification at their side.
What's the normal course of action when the one of the files your work is derived from has a different license to the rest of the repository?
Depends on the way you use it. I think, but IANAL, that we make a derived work from them in most senses of that statement. Assuming (and that's disputable, as you correctly point out) that the .proto
's are AGPLv3+, and we pull them through protobuf
, I think we technically may be "linking" against a binary version?
If we fall under "derived work", the whole should be under AGPLv3(+). If we don't, it's possibly disputable, but the most safe option would be AGPLv3(+) too, I guess.
from libsignal-service-rs.
Since our project has been re-licensed, I'll go ahead and close this issue!
from libsignal-service-rs.
Maybe then actually close it :-D
from libsignal-service-rs.
Related Issues (20)
- Send message HTTP status 428 not handled
- Remove e164 / phone number from ServiceAddress
- Refactor/merge ServiceCipher::open_envelope and ServiceCipher::decrypt
- Support contact discovery HOT 2
- Add support for ACI/PNI HOT 2
- PlaintextContent not handled HOT 2
- serde_json fails parsing empty HTTP 200 response HOT 1
- Groups v2 getAuthorizationForToday stopped working HOT 2
- Not sending SyncMessage if only linked device HOT 4
- Rework the pre-key management
- Upgrade to libsignal v0.31 or later
- Trigger PreKey-fetching on SessionNotFound
- Add ability to set user-agent HOT 1
- Can't send messages
- Receiving messages failed due to: `SignalProtocolError(InvalidKyberPreKeyId)`
- `TryFrom<EnvelopeEntity> for Envelope` contains strange (and outdated?) logic
- Attachments are encrypted with synchronous code in the executor HOT 1
- JSON Invalid Padding
- MessageSender::send_contact_details seems to have some parameters too many
- Groups Fail with Newly Linked Devices
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libsignal-service-rs.