Giter VIP home page Giter VIP logo

Comments (5)

whitep4nth3r avatar whitep4nth3r commented on June 4, 2024 2

I think I like 'Stay in time' — let's see how that works.

Love the additions, let's gooo!

from fretonator.

whitep4nth3r avatar whitep4nth3r commented on June 4, 2024

Love this idea!

from fretonator.

justinhhorner avatar justinhhorner commented on June 4, 2024

Awesome! Here's a mockup of a potential design for larger resolutions for both light and dark themes. I'd love to get your thoughts on it when you have the chance.

Thanks!
fretonator-metronome-mocks

from fretonator.

whitep4nth3r avatar whitep4nth3r commented on June 4, 2024

That's pretty nice Justin!

My suggestions are

  • add a title to the area perhaps? Just "metronome" is fine OR it could follow the same cadence as all the titles further up the page ... I have no clue right now 🤣
  • I know the thing works primarily with a slider, but I'd like to see the plus and minus buttons bigger - at least 44 x 44px for a11y
  • do we need a "bpm" anywhere?
  • what about time signatures and providing a different sound on the first beat of the bar? Is that overkill?

from fretonator.

justinhhorner avatar justinhhorner commented on June 4, 2024

Thank you!

  • What about a title like "Stay in time" or "Practice to a click"? For now, I have "Metronome" as the title.
  • Agree 💯. I've adjusted the size of those buttons.
  • Added "bpm".
  • Maybe we keep those features in mind and add them if we get requests to add more beyond the initial release. What do you think?

fretonator-metronome-mocks_02

from fretonator.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.