Comments (5)
Hey Max,
You must have followed the request from David Ng (@davidpng) on the flowkit issue ;)
Yes, if you want to tackle adding multiple data sets via the nextdata
keyword, give it a shot! I discussed this with David in email correspondence and my initial plan to handle this was:
a FlowIO utility function that takes one of these as input and returns a list of FlowData instances. This would allow me to throw an error from the FlowData constructor that would propagate to the FlowKit Sample class, and that error would indicate to use the new FlowIO utility function. Once you have a list of FlowData instances you can export them as new FCS files for consumption in FlowKit or any other library.
I think this is a better approach than adding an argument to the FlowData constructor to choose the data set to use for the FlowData instance. We can discuss the rationale for that in more detail if you want. The issue with this method is the replication of byte-parsing code in the new function and the FlowData methods. Those methods could be refactored out to common utility functions used by both.
If you want to give it a shot, create a new branch off of develop
. One requirement is not to add any external dependencies, I try to keep FlowIO as light as possible.
Thanks,
Scott
from flowio.
Hey Scott,
my first plan/ idea was to stick with the flowCore behavior and throw a warning that multiple datasets where found and load the first one. But your approach sounds good, but looks like a bigger operation.
I'm not even sure if this is a common case with .fcs files, I only found on till now and I'm not sure if I would be allowed to upload it as a test case. Is it ok if I tell you next week, whether I try to solve this task? I will be away the next couple of days.
Have a nice weekend,
Max
from flowio.
Hey Max,
No worries, don't feel obligated in any way to take it on. I won't have time before next week to get to it either. Think about it and let me know next week.
You have a great weekend as well!
-Scott
from flowio.
Hey Scott,
I won't be able to take the task now, but I will check in if it still needs to be solved, when there is more time.
But maybe it's good that your plans are documented here now, if someone else want to take over.
If my bosses give me the time to write the pull request, I will let you know.
Best wishes,
Max
from flowio.
Related Issues (10)
- Removing a channel HOT 2
- Missing set zeroes if data offsets are greater than header max data size HOT 3
- Error when exporting some FCS files: REPORT BUG: error calculating text offset
- Getting event data as an Int but expecting a float? HOT 2
- Missing license HOT 5
- Issue loading fcs files HOT 5
- FlowData.write_fcs attempts to write strings to file opened in binary mode HOT 5
- write_fcs mixes up PNN and PNS labels HOT 1
- Parsing an FCS file with variable int sizes fails raises an exception (and it could parse much faster) HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flowio.