Summary

This should be done to make way for #38. If the dependency is not present, unregister the wmmodel related services and commands.

Summary

In the new major version of wmcontroller, discovery happens through annotations, same as wmmodel. We should add these annotations to generated controllers.

Basic example

<?php

namespace Drupal\wmcustom\Controller\Node;

use Drupal\wmcontroller\Controller\ControllerBase;
use Drupal\wmcustom\Entity\Model\Node\Page;

/**
 * @Controller(
 *     entity_type = "node",
 *     bundle = "page",
 * )
 */
class PageController extends ControllerBase
{
    public function show(Page $page)
    {
        return $this->view('node.page', ['page' => $page]);
    }
}

Description

In the latest dev version of this module, usage of the @interact hook was removed in a couple commands. Since a couple of hooks also use this kind of hook, they are not triggered anymore.

Steps to reproduce

Create a new text field. The Allowed formats option is no longer there.

Expected result

Make sure all hooks are functioning again.

Actual result

Hooks are not triggered anymore.

Environment

Latest dev version of the module, latest version of Drupal.

Summary

Add a new option show-base-fields to the field:info command.

Motivation

Base fields are not included in the list of fields given by the field:info command. In some cases that would be useful.

Description

• Clean up unused branches (check Sourcegraph to make sure the branch is not directly required in a composer.json file)
• Switch default branch to main

• Remove usages of ChoiceQuestion
• QuestionTrait::choice should be replaced with something like this:

$question = (new ChoiceQuestion($question, $choices))
            ->setMultiselect(true);

        return $this->io()->askQuestion($question);

• QuestionTrait::confirm should be replaced with $this->io()->confirm($question, $default)
• QuestionTrait::askOptional is not necessary anymore. $this->io()->ask now asks optional answers by default. However, previously these were required. So go through the code and add required validation everywhere $this->io()->ask is currently used:

$answer = $this->io()->ask($question, $default, [static::class, 'validateRequired']);

public static function validateRequired(?string $value): string
    {
        // FALSE is not considered as empty value because question helper use
        // it as negative answer on confirmation questions.
        if ($value === NULL || $value === '') {
            throw new \UnexpectedValueException('This value is required.');
        }

        return $value;
    }

Summary

Add a new option is-translatable to the field:create command.

Motivation

All fields are created with the translatable property set to false. In some cases it would be useful to be able to create translatable fields.

field:meta produces the following command:

drush field:create node page --existing --field-name=field_meta --field-label=Meta --field-widget=inline_entity_form_simple --is-required=1 --target-type=meta --target-bundle=meta

which produces the following error:

 [error]  TypeError: Argument 2 passed to Drupal\wmscaffold\Commands\FieldCreateCommands::createField() must be of the type string

When calling field:create with the --existing option, the field type should be derived from the existing field storage.

Add a field-create hook to add the target-type option, just like entity_reference fields.

Add wmscaffold.settings config schema. Should fix the php_version key being automatically casted to a float.

• Add phpstan.neon config file referencing the wmcodestyle rule files (example)
• Add phpstan analyse to the coding-standards composer script
• Add autoload-dev entry to ensure autoloading during analysis

Description

We should check whether the taxonomy module is enabled when running drush vocabulary:create because now, after filling all inputs and without the module enabled, you get the following error:

The "taxonomy_vocabulary" entity type does not exist.

Description

When calling field-create to create a field based on an existing field storage, but the field already exists, you don't get an error until after you enter the remaining info.

Steps to reproduce

drush field:create node page --existing --field-name=field_meta --field-label=Meta --field-widget=inline_entity_form_simple --is-required=1 --target-type=meta --target-bundle=meta

Expected result

Add validation and a nicer error message.

Actual result

In EntityStorageBase.php line 499:

  'field_config' entity with ID 'xxx' already exists.

Environment

Latest dev version of this module, latest version of Drupal.

Summary

The wmmodel module removed its custom class discovery in favour of the annotation-supported Drupal 8 plugin system. The model generator should be changed to add the required annotation. Additionally, we could now customize in what namespace the classes should be placed.

Basic example

<?php

namespace Drupal\wmcustom\Entity\Item;

/**
 * @Model(
 *     entity_type = "item",
 *     bundle = "call_to_action"
 * )
 */
class CallToAction extends Item
{
}

Motivation

Support the latest version of wmmodel.

Summary

All the current command does is call the field:create command with a couple of options. If this issue can't be fixed within the field:create command, maybe we should create a custom command instead of calling that one.

Motivation

When using the field:meta command with an entity type without an existing field storage for this field, the command fails.

Summary

When generating a model for an entity type without configured base class, the command fails with the following error message:

Class  does not exist

Add some better error handling.

Summary

Provide documentation in a *.api.php file in your module's main directory. See the "implementing" section above for details of what this should contain (parameters, return value, and sample function body).

https://api.drupal.org/api/drupal/core!core.api.php/group/hooks

Summary

Add the ability to configure the namespace in which generated classes are placed (both models and controllers).

Motivation

To not impose a certain folder structure on users.

Summary

See wieni/wmcontroller#59 and wieni/wmmodel#20.

Summary

Add a new option field-description to the field:create command.

Motivation

Right now, it's not possible to set the field description when creating fields using the field:create command. In some cases it would be useful to be able to do that.

Summary

Allow ModelMethodGenerator plugins to provide a buildSetter method. Add support for generating these methods to ModelClassGenerator.

A non-functional, non-used method with this name has been present on ModelMethodGeneratorInterface and ModelMethodGeneratorBase for quite some time.

Motivation

Just like having getters on modules can be useful, sometimes we need setters for fields.

• Cleanup code using wieni/wmcodestyle
• Normalise composer.json
• Add LICENSE in case it's missing. Also add the license to composer.json.
• Add CHANGELOG.md (and UPGRADING.md, if applicable)
• Add issue & pull request templates
• Update repo description & tags
• Update README
• Update .gitignore
• Check dependencies: ensure composer.json has a php & drupal/core version requirements and add missing requirements to the .info file

Add hooks so we can change these options through drush nodetype:create.

Description

We're in the process of moving certain commands to Drush core. So far only field:create is merged.

• Rename module to entity_bundle_scaffold
• Create the Drupal project (example)
• Change the license to GPLv2 to comply with Drupal.org requirements (example)
• Update the composer install command in the README
• Add contributing section to the README (example)
• Create releases for existing tags on Drupal.org

Summary

Add an option to the wmscaffold.settings config to choose the output module instead of having to specify it as an argument in every command.

Motivation

Now you have to pass the wmmodel-output-module argument in every command that generates models. This creates a lot of unnecessary duplication.

Apart from that, passing default values for dynamic arguments in drush.yml broke in Drush 10, so automatically generating models after commands like eck:bundle:create is currently broken.

This command doesn't provide much added value. I don't think drush phpcs:fix is being used internally at Wieni. @RobinHoutevelts could you check SourceGraph to make sure this isn't being used anywhere?

Summary

ViewBuilder can be added as return type for the show method, but only in supported PHP versions.

Basic example

<?php

namespace Drupal\wmcustom\Controller\Node;

use Drupal\wmcontroller\Controller\ControllerBase;
use Drupal\wmcustom\Entity\Model\Node\Page;
use Drupal\wmtwig\ViewBuilder;

/**
 * @Controller(
 *     entity_type = "node",
 *     bundle = "page",
 * )
 */
class PageController extends ControllerBase
{
    public function show(Page $page): ViewBuilder
    {
        return $this->view(
            'node.page',
            ['page' => $page]
        );
    }
}

Summary

The entity type provided as argument to the command is not validated in advance, only after filling in the prompts you get an error.

Motivation

Improves the user experience.

Summary

When calling the field:delete command, also delete the field storage if this is the last bundle using it.

Motivation

When deleting a field through the field_ui form, the field storage is deleted if this is the last bundle using it. We should mirror this behaviour,

Summary

Make sure all options and arguments are documented with descriptions.

Motivation

Multiple command help screens are broken because a description is missing for their options and/or arguments:

Notice: Undefined index: description in Drush\Commands\help\HelpCLIFormatter->write()