wieni / wmsingles Goto Github PK

The $list is not initialized to array. So if there are no singles to get then a warning is popped.

-- Added $list = [];

    /**
     * Get all single content types.
     * @return array|mixed
     */
    public function getAllSingles()
    {
        $list = &drupal_static(__FUNCTION__);
        if (!isset($list)) {
            $list = [];
            /** @var NodeTypeInterface $type */
            foreach (NodeType::loadMultiple() as $type) {
                if ($this->isSingle($type)) {
                    $list[$type->get('type')] = $type;
                }
            }
        }
        return $list;
    }

Description

• Clean up unused branches (check Sourcegraph to make sure the branch is not directly required in a composer.json file)
• Switch default branch to main

Summary

Create derivative menu items under the existing menu item, containing all single node types with their entity operations.

Motivation

Quicker navigation.

• Add phpstan.neon config file referencing the wmcodestyle rule files (example)
• Add phpstan analyse to the coding-standards composer script
• Add autoload-dev entry to ensure autoloading during analysis

• Cleanup code using wieni/wmcodestyle
• Normalise composer.json
• Add LICENSE in case it's missing. Also add the license to composer.json.
• Add CHANGELOG.md (and UPGRADING.md, if applicable)
• Add issue & pull request templates
• Update repo description & tags
• Update README
• Update .gitignore
• Check dependencies: ensure composer.json has a php & drupal/core version requirements and add missing requirements to the .info file

Currently $type is not in the IF.

Sometimes it is null not sure why but when the module : drupal/admin_links_access_filter is on.

    /**
     * @param NodeInterface $node
     * @return \Drupal\Core\Access\AccessResultForbidden|\Drupal\Core\Access\AccessResultNeutral
     */
    public function access()
    {
        /** @var NodeTypeInterface $type */
        $type = $this->currentRoute->getParameter('node_type');

        if ($type && $this->wmSingles->isSingle($type)) {
            return AccessResult::forbidden();
        }

        return AccessResult::allowed();
    }

can I join?

• Create the Drupal project (example)
• Change the license to GPLv2 to comply with Drupal.org requirements (example)
• Update the composer install command in the README
• Add contributing section to the README (example)
• Archive this repository, make it point to the new one
• Abandon the package on Packagist and put drupal/node_singles as replacement (example)

In 40e70a7 a dependency to wieni/wmcontroller sneaked in 👀

It's safe to just swap to core's ControllerBase instead.