wiiiiam278 / husktowns Goto Github PK

Throwing an enderpearl inside a claim with pvp disabled still throws the "PvP is disabled..." message even if no player is present or hit.

Not sure what else to say... it's protection... around spawn... for a configurable amount of blocks from World Spawn... definitely in scope and really a huge oversight to not have considering admin towns now incorporate flags.

A permission for players to monitor all conversation happening in Town Chats.

Toggle-able by Command and implemented by a Permission.

Suggested by Discord user: GrandpaCrunkle#3763

Add a remove town/claims after x amount of days of player inactivity.

Adding onto this: perhaps making it a setting, allowing for it to either transfer or remove the claims and then a setting for inactivity count. The aforementioned transferring might have to be done just by pulling the member list of the town and choosing the earliest member to become the "owner".

/townbonus add <player> <bonus claims> <bonus members> should work.

double apostrophe ('') is used

If you have HuskChat and HuskTowns installed together it looks like you cant toggle your town chat using "/town chat".
Messages will still be send in your Channel selected via HuskChat.

For Moderation purposes it is required for players to excluded from the permission block allowing them to view chest contents and other wise.

husktowns.override | /town override

Seems logical to also support this aswell

Brief:

• Withdrawl from Coffers; limited to amount to sustain current Chunks/Members.
• Setting Plot prices/Rent costs. Directly funds town coffers thus town level (configurable)
• Taxation on Towns server wide -- admin command.

Info extrapolated from Roadmap. See for further and expanded info.

Same for explosions but for the spread of fire. 🔥

Plazes chunks are a "catch case" chunk; this meaning they allow for interactions of entities and other but do not allow the interactions on Blocks or opening containers (see RoadMap).

Further discussion may take place but please familiarize yourself with the RoadMap entry before hand.

Requires me doing a bunch of tedious Towny API testing and work. I'd also like to get taxable / price set town plots done first as that's a major feature. Towny also has a bunch of stuff that Husk Towns does not like nations.

Taken from the Roadmap. Check for updates.

If anyone has any suggestions or ideas on how we should handle issues like the nation system import, please leave a comment in this ticket. This lets us compile everything, and hear feedback.

This issue is marked as postponed; this is not correct but it's priority is considered so low that postponed is the best gauge

So with custom role prefixes... Provide a spot in the config that allows us to change the prefix of a resident, mayor, and trusted. For example if I put %husktowns_town_role% placeholder in my scoreboard and the player was just a resident it would obviously say "Resident". I want to be able to change to format maybe to "RESIDENT" or "[RESIDENT]".
Original Suggestion by Seth#2764

Add a /flags or /town flags, so that leaders can deactivate certain options in their town, for example pvp, explosions, friendly fire, >etc.
Original Suggestion by Syndr4

Town Flags and Admin Flags should be done seperate

• Towns owned and kept active by a dummy player
• These towns are always active (i.e. they can not be deleted by a player only by an admin)
• "/admintown create [town]"

Admin commands are commands that fall under the /townadmin or any proxy command using the Admin name in them or an abbreviation of such. These commands are to be used by any operator or owner of the server. They may be entrusted to others. These commands can cause major irreversible changes if used incorrectly or given to the wrong people.

These commands serve to greatly help and assist admins in Administration and Moderation tasks. Thus, due to the poor state they are currently in an overhaul is needed to the system.

• These commands shouldn't focus on being Simple; they should be powerful.
  • These commands don't need to be simple, they need to be usable, to do what they set out to do. Exchanging some of the simplicity isn't the worse case.
• They should be locked behind individual nodes
  • Sometimes "Admin" commands should also be available to moderators. So lets support that.
• They should support most of the features we have available that would require Administration
  • We can't be expected to support commands that aren't needed. It's un-needed bloat

Potential Admin Commands:

Potential Admin Town Commands:

Logs:

[01:41:08 INFO]: b01w issued server command: /town create Poggers
[01:41:08 WARN]: [HuskTowns] Plugin HuskTowns v1.3.1 generated an exception while executing task 5442
java.lang.NullPointerException: Cannot invoke "net.milkbowl.vault.economy.Economy.getBalance(org.bukkit.OfflinePlayer)" because "" is null
at me.william278.husktowns.integrations.Vault.takeMoney(Vault.java:49) ~[?:?]
at me.william278.husktowns.data.DataManager.lambda$createTown$17(DataManager.java:1639) ~[?:?]
at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftTask.run(CraftTask.java:100) ~[patched_1.17.jar:git-Purpur-1243]
at org.bukkit.craftbukkit.v1_17_R1.scheduler.CraftAsyncTask.run(CraftAsyncTask.java:57) ~[patched_1.17.jar:git-Purpur-1243]
at com.destroystokyo.paper.ServerSchedulerReportingWrapper.run(ServerSchedulerReportingWrapper.java:22) ~[patched_1.17.jar:git-Purpur-1243]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130) ~[?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630) ~[?:?]
at java.lang.Thread.run(Thread.java:831) [?:?]

Only edited the messages yml and changed the husktowns name to mineconomy names and also the colours. Any reason why this is happening?

Original Request by GrandpaCrunkle#3763

Admin Autoclaim :]

Adding on: this appears to be an oversight with the autoclaim feature.

Currently town greeting and farewell messages are completely up to players to format but this probably should not be the case. For example, players can spoof server messages. https://i.gyazo.com/824a1bd47bc091d17282ac45c2e560cd.gif

Should be by default (in town color): Entering/Leaving : and have this be configurable in the messages file

Increasing the size of the particle (Sometimes its easy to lose sight of especially with shaders)

Also increasing the particle ratio and maybe making it slightly scattered across the border Y axis may be applicable.
Or in other words, displacing on the Y axis to make it contrast against walls.

Towns that you can join without needing an invite

Taken from the Roadmap. See for further info

Currently missing strings from locale file:

• Town overview menu
• Town map hover informational details
• Claim list hover informational details

See also: WiIIiam278/HuskTownsDocs#52

Not currently going to happen:

• Command descriptions (as these are taken from spigot's plugin.yml file)

"At the moment there's a bunch of stuff that you can't customize the color of due to technical restrictions."
Taken from the Roadmap

Just a message saying "Are you sure you want to spend X to do Y?"

Taken from the Roadmap. See for further.

Distinguish chunk types (Farm, Plot, Player Location etc.) by Symbols on the map, allowing for better visibility.
This should probably be toggle-able in some way or modifiable for what would show.

java.lang.NullPointerException: The expansion version is null!

Server Consoles seem to be re-sending the cache system time when a server goes from 0 players to 1. It reports normally fairly high numbers which it seems to be counting constantly in the background.

Example:
Player joins right as server starts:
Cache time is 100 seconds
They Leave

50 seconds later they rejoin:
The cache system says 150 but is instant.
They leave

So on and so forth...

Allow non-town residents to use /town spawn to visit someone else's town.

When using AutoClaim, you should be able to toggle a automap system that will display the map when you claim a new chunk.

"/autoclaim map" as the command?

Containers are not protected by other players (who are untrusted).

Currently on startup the plugin loads ALL the data off the database into memory. In the case of claims, the plugin restricts most actions until loading is complete. This is bad for a number of reasons:

• The more claims and players who play on the server, the longer this load time will be. A server with 3000 claims takes around 3 minutes to load. Servers with hundreds of thousands of claims in the future could take hours.
• Although the memory usage overhead is pretty low (only kilobytes), it will scale. The memory usage might be noticeable with servers with many hundreds of thousands of claims, players, etc
• Slow databases will load data even slower.

Here's the plan:

• Make the player cache only load players when they log in and remove them from the cache on logout.
• Make the claims cache smarter by caching data when first used and removing the data after not being used for a prolonged period of time.
• Make the messages cache only load messages for towns with claims on the server.
• The town bonuses cache can stay the way it is.

Looks like "outsiders" can still interact with buttons, Redstone stuff etc even if "Public Interact Access" is set to FALSE

Doors seems to be fine on my end, as far as I'm aware.

Requires me doing a bunch of tedious Towny API testing and work. I'd also like to get taxable / price set town plots done first as that's a major feature. Towny also has a bunch of stuff that Husk Towns does not like nations.

Taken from the Roadmap. Check for updates.

If anyone has any suggestions or ideas on how we should handle issues like the nation system import, please leave a comment in this ticket. This lets us compile everything, and hear feedback.

This issue is marked as postponed; this is not correct but it's priority is considered so low that postponed is the best gauge

Reproduction Steps:

Simply do /town deposit and then insert a number that will the counter below 0. If there is money in the account it will be refunded if not it will down below.

Original request made by GrandpaCrunkle#3763
Message in #suggestions done by William278 [devoloper]

Abandon all town claims function w/ confirmation

E.g emboldened text in the prefix is not able to be reset

maybe add a command that shows all the borders of your claims to show instead of just the current chunk you are in.
Original Suggestion by Sethh#2764

Good idea. There’s /map that shows all nearby claims but how does shift+click with a stick to view all nearby borders sound?
Further continued idea by William#5204

When you run the /claimlist command the list that appears is randomly sorted each time you re-run the command.

• Be in a town that has multiple claims set
• Type /claimlist once
• Type /claimlist again
• 🚫Observe that the claims in the list are ordered differently

/town invite doesn't auto-tab. Plain and simple

By default towns should be colored based on their name but an option should be added to let them change this to any color they want.
Involves storing town color hex code in the town table on SQL, adding to the town settings menu and adding command to handle changing it, as well as caching it in the town data cache and then updating the cache, etc.

"I'd like to make it so /town help displays a list of the /town subcommands rather than the big generic help menu. This will be more intuitive and helpful for new players. The old help menu will still be accessible with /husktowns help."

Taken from the Roadmap.

Reported by GrandpaCrunkle#3763

Also it seems with 1.17 that the claims for Dynmap no longer appear on the map

Can not confirm or test as no HuskTowns jar is available for use.

When doing /town spawn for another players town whilst on another server. Being sent to the other server will send you to your own town.

This was removed in 1.2.4, should be re added as could lead to exploits

Crossbows appear to still inflict damage in a Town, with or without a combat plugin or state being enabled or disabled.

Original Request by GrandpaCrunkle#3763

Town upkeep cost/Town Taxing :]

William see GIF sent via DM's.

Downside of this is that it won't work with Bungee Chat and such... But it'd be very useful and nice to have :)

Implementation of a Command that will, when used, claim in a square shape the surrounding chunks as supplied in the command.

/claim <no.>