Process internal JSON to obtain Wikibase data objects about wikidata-toolkit HOT 4 CLOSED

When converting value snacks, I need to map the property IDs to some internal representation (I do not want to create a switch-case-statement for looking up magic numbers). So for now I would suggest to just create an enumeration for the mapping. This lookup is needed since different properties do have different value types, on wich in turn depends how to convert them.

from wikidata-toolkit.

I don't quite understand the comment. The property ids are represented by PropertyIdValue objects internally. One can directly create such objects from property ids using a base URL of the website that the data is for. There is an unknown number of properties and each website may have different properties, so it would be impossible to hardcode them in a switch statement anyway. ,OTOH, the type information that is provided for each primitive property value should be enough to convert the value to an object, even if the property is not known at the time. It is not necessary to evaluate that the primitive value matches the property datatype.

from wikidata-toolkit.

The conclusion we came to vis-a-vis for the record:

I overlooked, that all the property data types are also represented as strings in the dumpfile JSON value snaks.
This makes the whole thing pretty trivial.

from wikidata-toolkit.

This is largely closed now with the merge of #29. However, some details are not done correctly yet (esp. related to sitelinks; see also FIXMEs in JsonConverter.java) and need to be addressed in the future.

from wikidata-toolkit.