wildan3105 / cfc-schedules-tweet Goto Github PK

See the below screenshot: we should handle game_spotlight field if present and convert tomorrow as new Date() + 1 day.

Is your feature request related to a problem? Please describe.
Sometimes SERP API changes the returned response structure.

Describe the solution you'd like
We need a way to ensure the contract is consistent and if it's not, we need to alert it to mitigate.

Describe alternatives you've considered
Possible alternatives:

• healthcheck endpoint runs every period
• service-level testing to cover it

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
Inconsistent result of serp API response. The object of sports_results are sometimes missing from the response body.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
Can't see where is Chelsea playing at.

Describe the solution you'd like
Stadium name.

Describe alternatives you've considered
N/A

Additional context
N/A

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Describe the bug
Take a look at data stored in redis below:

{
	"tournament": "Premier League",
	"stadium": "Stamford Bridge",
	"date": "Sep 4",
	"time": "8:00 PM",
	"teams": [{
		"name": "Chelsea",
		"thumbnail": "https://serpapi.com/searches/62e5e267aa6c9517ee5ad5e3/images/67d91fa9660009fd8f18601a5e078d6d867ce20a2bc720d250075bafc66db5700d7bc486c80ac592b18558af27e6452f.png"
	}, {
		"name": "West Ham",
		"thumbnail": "https://serpapi.com/searches/62e5e267aa6c9517ee5ad5e3/images/67d91fa9660009fd8f18601a5e078d6d867ce20a2bc720d2352f8c11b8b1bab84d79497af931ee60fd8e632ac14832f4.png"
	}],
	"participants": "@ChelseaFC vs West Ham",
	"date_time": "2022-09-01T13:00:00.000Z"
}

To Reproduce
Sep 4 is somehow converted into Sep 1st

Expected behavior
Date conversion should be Sep 4

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Describe the bug
Game highlight:

• date and time are in the date object
• use league

Sport results:

• date and time are separated
• use tournament

Is your feature request related to a problem? Please describe.
Handle shutdowns in the following:

• cron (fetcher and reader)
• worker (match subscriber)

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

pm2 is not used anywhere in this code. it should be removed to reduce the dependencies at run time.

Describe the bug

2024-01-27T04:51:46.247315+00:00 heroku[scheduler.4201]: Starting process with command `node build/jobs/match-reader.js`
2024-01-27T04:51:46.888854+00:00 heroku[scheduler.4201]: State changed from starting to up
2024-01-27T04:51:47.431463+00:00 heroku[scheduler.4201]: Process exited with status 1
2024-01-27T04:51:47.379260+00:00 app[scheduler.4201]: an error occured TypeError: Cannot read property '0' of null
2024-01-27T04:51:47.379309+00:00 app[scheduler.4201]: at /app/build/jobs/match-reader.js:28:47
2024-01-27T04:51:47.379309+00:00 app[scheduler.4201]: at Generator.next (<anonymous>)
2024-01-27T04:51:47.379309+00:00 app[scheduler.4201]: at fulfilled (/app/build/jobs/match-reader.js:5:58)
2024-01-27T04:51:47.379309+00:00 app[scheduler.4201]: at processTicksAndRejections (internal/process/task_queues.js:97:5)

To Reproduce
Steps to reproduce the behavior:

1. Delete the redis key (fixtures)
2. Let the match-reader cron runs

Expected behavior
We should handle more gracefully, i.e. only log and send alert/warning/info depending on the error type (retryable/known/unknown/etc.)

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Right now, we don't tweet tournament if present. We should handle this. LOC:

Describe the bug

cleanseDate to return month and date only when format is ddd, D MMMM (8 ms)

To Reproduce
See:
https://github.com/wildan3105/cfc-schedules-tweet/actions/runs/5962196898/job/16172915644?pr=33
Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Is your feature request related to a problem? Please describe.
Currently, in #22 tournament would be written in plain text. For example, Premier League will be as it is A.K.A "Premier League". We should transform it to searchable hashtag so that people can easily find it.

Describe the solution you'd like
List of associated hashtag to its corresponding tournament/competition:

• Premier League -> #PL
• UEFA Champions League -> #UCL
• FA Cup -> #FA

and so on

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Is your feature request related to a problem? Please describe.
For day-1

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.