wildhoney / ngcrossfilter Goto Github PK

Hi,

First thanks a lot for this awesome angular module. I use it to create sortable and filterable grids.

I have an issue when trying to update a model. I assumed the way to do that was to remove the model and then add the new updated model.
I do something like
$scope.$ngc.deleteModel(model);
$scope.$ngc.addModel(updatedModel);

The model gets deleted correctly but it doesn't get added then. It seems I can't add a model which have been deleted before. Could you help with that ?

Many thanks

Hello,

I use ngCrossfilter with dc.js. It looks like dc can not render charts (called by a dc.renderall() ) because 'crossfilter' is not available :

angular.js:13920 TypeError: Cannot read property 'quicksort' of undefined
    at Object._chart._computeOrderedGroups (base-mixin.js:335)
    at Object.<anonymous> (cap-mixin.js:51)
    at Object._chart.data (base-mixin.js:261)
    at drawChart (row-chart.js:136)
    at Object._chart._doRender (row-chart.js:89)
    at Object._chart.render (base-mixin.js:645)
    at Object.dc.renderAll (core.js:230)
    at pages.controller.js:85
    at processQueue (angular.js:16383)
    at angular.js:16399

The base-mixin.js:335 is :
_orderSort = crossfilter.quicksort.by(_ordering);

And crossfilter is not available, because it is defined only into the new Crossfilter() object...

Is there a solution to have the crossfilter object available into dc.js ? Or did I misunderstood anything ?

Thanks.

Currently the bower.json specify the angular dependency as "angular": "~1.2.1"
This should be updated to "angular": "~1.x.x" to support any all legit angularjs versions.

loading the demo app fails with

404 loading: http://ng-crossfilter.herokuapp.com/js/vendor/underscore/underscore.js

I was listening for updates in a crossfilter using the crossfilter/updated event, but I couldn't find a clean way to identify from which crossfilter the event originated when there's more than one.

Maybe I'm missing something, but I guess a backwards-compatible approach would be to optionally set a name/id for a crossfilter and pass that name along with the broadcasted event. It could look something like this:

$scope.ngc = new Crossfilter(response.data, 'id', 'persistent');
$scope.ngc.setCrossfilterName('myCrossfilter1');

$scope.$on('crossfilter/updated', function(event, collection, crossfilterName) {
  if ('myCrossfilter1' === crossfilterName) {
    // ...
  }
};

Thoughts? I'm happy to submit a PR if you think it's worth it!

Hi, I like the idea, but I m not getting the clear benefits of using ngCrossfilter over crossfilter directly in the controller, like I use Lodash. Can you please clarify? Thanks.

your package could not be found and installed via bower
check it out please.