Giter VIP home page Giter VIP logo

spicetify-fluent's People

Contributors

mvahaste avatar n-35 avatar rlaphoenix avatar salaron avatar sanoojes avatar sistematico avatar thehenkka avatar wian-lloyd avatar williamckha avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar

spicetify-fluent's Issues

Fluent theme is broken

Computer info

Spotify version: 1.71.560.gc21c3367
Spicetify version: 2.7.1

Issue

Play and track control buttons don't work, alongside other pieces of UI that seem to be broken.

Screenshot

IMG-20211101-WA0039.jpg

Playlists in folders become too small to read

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: Spotify for Windows 1.1.81.604.gccacfc8c
- Spicetify version: 2.9.5
- Fluent installation method: Github readme

๐Ÿ“ Description

When folders are opened, the playlists inside of them are indented, which means that after one or two layers of subfolders, they are unreadable/extremely thin. Perhaps a vertical way of dividing folders (using e.g. a line to divide folders) would be good.

๐Ÿ“ธ Screenshots

image

Some UI is now showing

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

Display 1920x1280
Thinkpad t450

๐Ÿ“ Description

The UI is gone

๐Ÿ“ธ Screenshots

image

Play button not displayed properly.

โ„น Computer information

  • Spotify version: 1.1.63.568.gda8cb5ac-a
  • Spicetify version: 2.5.0-itsmeow-patch4

๐Ÿ“ Provide detailed reproduction steps (if any)

just install theme in powershell as normal

โœ”๏ธ Expected result

The play button should be displayed normally

โŒ Actual result

The play button is displayed as a round rectangle

๐Ÿ“ท Screenshots

image

Top Bar Header inconsistent styling, alignment, weird boxes

image

When the top bar header appears, so do these weird little boxes that I presume are related to the static table header.

Since Spotify's update, I'm not sure what is intended for the Play button in the header is to look like as Fluent.

Edit: The two rectangles highlighted on the side have since been fixed and merged in master. The alignment of the text at the top is still off. However, it seems to be another problem relating to line height relative to the font-size changes, that will need a separate fix.

Control Bar has white Play Button

**Describe the bug
White Play button using Fluent skin

To Reproduce
Steps to reproduce the behavior:

  1. Open spotify
  2. See the play button is white

Screenshots
image

Specifics:

  • OS: Windows 10 21H1 / 19043.1266
  • Spotify version: 1.1.69.612.gb7409abc
  • Spicetify version: 2.7
  • Theme name: Fluent (Latest Version)

I even cleared backup, redownloaded the theme file, etc. Same issue**

misaligned icons

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: 1.1.94.870.gf994cb0b
- Spicetify version: 2.13.1
- Fluent installation method: GitHub Readme

๐Ÿ“ Description

Installed theme, edited the patch value in cofig and applied the theme

I saw this issue already asked but now it arises again

๐Ÿ“ธ Screenshots

image

xpui.js not found

in powershell, in the patching section:
xpui.js not found

I can find config-xpui.ini but I don't know what to do with the xpui.js
Also some things are duplicated in the UI
image

Unable to reach last few playlists due to sidebar padding change

The commit da49e6a has resulted in being unable to reach the last few playlists.

This method of applying the scrollbar is problematic and the reason I did not originally do this for the pull request.
If you have a lot of playlists, to the point where you need to scroll down, the playlists will then be underneath the main playback bar.

image

Removal of Upgrade button and any other ad-blocking shouldn't be done by Fluent

By default, for legal reasons, it shouldn't be done. However, there's also UX reasons not to do so. Some people might want to have that upgrade button if their Premium runs out.

If the user then still doesn't want the upgrade button, they could either remove it via Spicetify Marketplace -> Snippets -> Hide Upgrade Button, or remove it via BlockTheSpot (which those users will most likely be installing anyway).

It can also be done (and done better) with https://github.com/Daksh777/SpotifyNoPremium

The UI is partially broken and doesn't adjust to fit the window

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: Spotify for Windows 1.1.83.956.gbe7ea9a7
- Spicetify version: 2.9.6
- Fluent installation method: powershell or marketplace

๐Ÿ“ Description

For the most part, the interface doesn't display the sidebar's icons correctly, and certain items in the dark color scheme are barely readable or transparent.

It also has an issue with the window scale, which causes it to not fit the screen correctly.

๐Ÿ“ธ Screenshots

Don't mind my bad music taste....
image

See Playlist Name via Hover Tooltip

Since we cannot reasonably add support for a resizable sidebar to see the playlist names, one option would be to add an on-hover tooltip to see the playlist name.

Home page always fails to load on first startup

This might or might not be a Fluent problem.

image

I get this on the homepage every time I start up Spotify. Once I click Reload Page, it seemingly never happens again.
When checking devtools I get the following information:

Uncaught (in promise) InternalServerError: GET request to sp://ads/v1/ads/hpto failed with status code 500
    at d.onSuccess (xpui.js:1:1490925)
    at onSuccess (xpui.js:1:1490739)
TypeError: Cannot read properties of undefined (reading 'rendering')
    at xpui-routes-home.js:1:1650
    at Array.find (<anonymous>)
    at xpui-routes-home.js:1:1617
    at xpui-routes-home.js:1:1832
    at Ca (vendor~xpui.js:29:3300340)
    at Is (vendor~xpui.js:29:3324072)
    at t.unstable_runWithPriority (vendor~xpui.js:29:3545451)
    at hi (vendor~xpui.js:29:3269876)
    at Rs (vendor~xpui.js:29:3323851)
    at Os (vendor~xpui.js:29:3308730)
TypeError: Cannot read properties of undefined (reading 'rendering')
    at xpui-routes-home.js:1:1650
    at Array.find (<anonymous>)
    at xpui-routes-home.js:1:1617
    at xpui-routes-home.js:1:1832
    at Ca (vendor~xpui.js:29:3300340)
    at Is (vendor~xpui.js:29:3324072)
    at t.unstable_runWithPriority (vendor~xpui.js:29:3545451)
    at hi (vendor~xpui.js:29:3269876)
    at Rs (vendor~xpui.js:29:3323851)
    at Os (vendor~xpui.js:29:3308730)

Is the sidebar resizable?

Not sure if this is where I can post such a question, so apologies if I'm in the wrong place. I was wondering if any of the sidebars are sizable (normal sidebar and friends activity). If not, is there a way I can get the name of the playlist that's in the sidebar? It would be nice, since when I don't know what the playlist cover looks like, I need to click each one to find the one I'm looking for.

Creation of Release Versions

๐Ÿ“ Provide a description of the new feature

Currently, users have no idea what versions are supported or how up-to-date the repository is relative to Spicetify and Spotify updates.

We could start making release versions of the project instead, following SemVer where each major update represents support for the next Spotify major update.

E.g., Assuming we start the first release at 1.0.0 indicating support for what we have now, 1.80.x. Then a 2.1.2 release would indicate support for Spotify 1.81.x and has 1 feature update, after which has also had 2 fixes.

We could also go the route of just releasing starting with the major version, e.g., 80.0.0. Therefore 81.1.2 would then indicate the same as before. This route is more readable but indicates that the project has gone through more updates than it actually has.

โž• Additional Information

I cannot say versioned releases for Spicetify themes are common, but it has been done before by @JulianMaille. You can see some examples of the route he has taken here:

As for documentation of releases, we can use the Keep a Changelog spec to keep it tidy, readable, and to the point.

Clicking on playlist jumps playlist slider to top

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: Spotify for Windows
1.1.93.896.g3ae3b4f3
- Spicetify version: latest on marketplace
- Fluent installation method: Marketplace

๐Ÿ“ Description

  1. Scroll down to play playlist lower down on your playlist bar list
  2. Click playlist icon
  3. Try to click it again to play the playlist
  4. You cannot, because the scrollbar jumps up, so you cannot doubleclick to play
  5. Now you must scroll down and then press it again to play

๐Ÿ“ธ Screenshots

1
^ Default on app open
2
^ After Scrolling down
3
^After pressing a playlist on the bottom

Add this repo to the spicetify marketplace

Fluent theme is available in spicetify marketplace from this repo. But the theme is not updated to current state and have some glitches.
If this repo will be added to marketplace, users can get latest fixes faster.

Sorry for my English.

sidebar playlist covers bug

hello, the images don't fit/shrink in the sidebar.
image

spicetify version: 2.6.4
spotify version: 1.1.68.628

how can i fix this?

Playlist icon width is inconsistent

Playlist icons are sometimes wider than expected, which also cuts off the bottom of the image for the playlist. This seems to only affect playlists which have been downloaded and are not currently being played. Playlists that are either not downloaded, or have been downloaded and are currently playing have the expected width.

This may be because the download-icon has no CSS mapping for the class name GN_mYTMDEtwPsSIMKxez (which would be a spicetify bug rather than this theme).

(background colour changed to white to help show problem)

spicetify-fluent-playlist-width

Enabling of the Discussions page

๐Ÿ“ Provide a description of the new feature

The Discussions feature is a relatively new addition by GitHub and is useful for general discussion that may be worthwhile to bring up but not as an Issue, as it may not directly be an issue.

For example, this issue would have been a candidate for a Discussion. Or perhaps general help, questions, or talk about the project.
We cannot currently do this without clogging the Issues tab.

โž• Additional Information

This can be enabled quite quickly in the Settings page near the end.

Offcenter Icons

Latest version of Spotify, Spicetify, and Fluent. Tried Uninstalling and Reinstalling about 3 times and every time the icons were offcenter.
Screenshot 2021-10-29 163342

Dark mode background is whited out

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: `1.1.80.699.gc3dac750`
- Spicetify version: `2.9.5`
- Fluent installation method: (e.g., GitHub Readme, Spicetify Marketplace): `Marketplace`
- Operating system: `Void Linux`

๐Ÿ“ Description

Background is whited out like it's expecting a compositor, even when a compositor is running.

Possible causes:

  • It looks like it's using my GTK theme for some reason
  • It might not like picom

๐Ÿ“ธ Screenshots

2022-04-21-100545_1920x1080_scrot

Unable to scroll down to the bottom of playlists

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: Spotify for Windows 1.1.81.604.gccacfc8c
- Spicetify version: 2.9.5
- Fluent installation method: GitHub Readme

๐Ÿ“ Description

When scrolling down the playlist list, I cannot get to the final few playlists (this is true even when playlist folders are expanded). This is usually the case with or without a scrollbar; but opening different folders allows me to scroll to different amounts.

๐Ÿ“ธ Screenshots

image

Double listing in Marketplace

Hey I just noticed that your theme is listed twice in Spicetify Marketplace. I thought it was a bug, but it looks like it's because it's listed in the manifest here as well as in the community themes repo. Would it be alright with you if we removed it from the community themes manifest? It would still be included in the community themes github, it just wouldn't be in the manifest file so it wouldn't show up twice anymore. Or we can do the other way around if you'd like, but I figure it makes more sense to list this one.

All icon assets are not showing

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: 1.1.79.763
- Spicetify version: 2.9.8
- Fluent installation method: (e.g., GitHub Readme, Spicetify Marketplace): GitHub Readme

๐Ÿ“ Description

  1. Load Fluent theme
  2. Load fluent.js
  3. apply the theme
  4. Open Spotify

No icons will be loaded including media controls

๐Ÿ“ธ Screenshots

image

Floating Control Bar Bouncing + Unaligned Icons

๐Ÿ” Is there already an issue for your problem?

  • I have checked older issues, open and closed

โ„น Environment / Computer Info

- Spotify version: Spotify for Windows 1.1.89.862.g94554d24
- Spicetify version: Spicetify v2.10.2
- Fluent installation method: (e.g., GitHub Readme, Spicetify Marketplace): Github (tried both manual and automatci

๐Ÿ“ Description

Icons are not aligned and the floating control bar keeps bouncing up and down. I have also used the patch.
I have attached a screenshot and gif. (Sorry if the gif is low quality)

Edit: It seems like a new UI 'footer' is appear causing the control bar to be pushed up while it is active.

๐Ÿ“ธ Screenshots

image
nefikjov

Class .contentSpacing max-width adds too much white space 1440p.

Love this theme! โ™ฅ
Wouldn't really classify this as an "issue" but might be nice for future reference.

Found that at a resolution of 2560x1440 .contentSpacing doesn't span full width.
I might have more files loaded that might be causing this but I'm unsure how to check(Spicetify newbie).

image

Did some finds in

  • .spicetify\Themes\Fluent\fluent.js
  • .spicetify\Themes\Fluent\user.css

Didn't see any modifications to the .contentSpacing class so I added an !important rule to .spicetify\Themes\Fluent\user.css.
Quick and dirty, but does the trick!
.contentSpacing { max-width: 100vw !important; }

image

Follow system theme

๐Ÿ“ Provide a description of the new feature

Basically use the light mode when system is in light mode and dark when the system is in dark mode

โž• Additional Information

No response

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.