Giter VIP home page Giter VIP logo

Comments (8)

lehno avatar lehno commented on August 11, 2024 1

That is great, thanks again

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024 1

@lehno Sorry for the delay. Released as v2.0.1. Please let me know if it works.

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

@lehno can you npm i @types/express --save-dev?

from nestjs-prometheus.

lehno avatar lehno commented on August 11, 2024

Do I need to use @types/express even when using Fastify?

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

Because I wrote the controller using express's response, they would be needed yeah. I can probably rewrite it so it doesn't require one vs the other.

Do you happen to have skipLibCheck enabled in your tsconfig?

from nestjs-prometheus.

lehno avatar lehno commented on August 11, 2024

I don't have skipLibCheck enabled. Using all default values from NestJS and changed Express to Fastify for performance.
Tks for the explanation

from nestjs-prometheus.

willsoto avatar willsoto commented on August 11, 2024

As a workaround, I would suggest enabling skipLibCheck since I believe it makes it so your application won't have an issue if there are typings issues in other people's libraries (like this case).

I have marked this as a bug though since I don't think it's reasonable for people to have to install typings for express if they aren't using it OR have to tweak their tsconfig settings to use this library.

I'll try and get a fix out in the next few days.

from nestjs-prometheus.

lehno avatar lehno commented on August 11, 2024

I will test soon

from nestjs-prometheus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.