willviles / ember-google-analytics-embed Goto Github PK

Ember Google Analytics Embed 0.1.6 release ensures all events are removed on the willDestroyElement hook. However, Google Analytics embed API still throws a Cannot read property 'firstChild' of null error if a component is removed whilst it is initializing a new chart.

// components/visualizations/base-chart.js

createVisualization() {
  // Component is present on initialization...
  const container = this.elementId;

  return new window.gapi.analytics.googleCharts.DataChart({
    chart: { container }
  }); // => But during chart insertion, component is destroyed.

  // => `Cannot read property 'firstChild' of null` from `cb=gapi.loaded_0:455`

},

Not entirely sure how to silence this error - any help appreciated!

Fix deprecation warning on didUpdateAttrs by removing arguments and registering an observer using addObserver for each possible chart option.