Updating from 0.6.1 to 0.7.1 causes the build to fail about ember-useragent HOT 8 CLOSED

Yes, by submitting this line as a PR to ember-useragent:

importTransforms: require('ember-cli-cjs-transform').importTransforms

We could fix the crash for host apps that don't have ember-cli-cjs-transform installed.

However, that would cause this (apparently harmless) warning:

WARNING: Addon "ember-cli-cjs-transform" is defining a transform name: cjs that is already being defined. Using transform from addon: "ember-cli-cjs-transform".

The alternative is to

• instruct users of ember-useragent to install ember-cli-cjs-transform
• automatically install ember-cli-cjs-transform during the installation of ember-useragent

tbh I'm just eagerly awaiting embroider-build/ember-auto-import#119 so that we can use it instead of the CJS transform.

from ember-useragent.

What platform are you on?

from ember-useragent.

This is probably a case of: rwjblue/ember-cli-cjs-transform#22

The solution above isn't ideal, since it probably generates these warnings in host apps that already have ember-cli-cjs-transform themselves as a dependency, but it appears to be a valid fix.

from ember-useragent.

@buschtoens is there anything I can do to bypass this warning? the reference to rwjblue/ember-cli-cjs-transform#22 seems to reference a chance required to this addon, or are you suggesting a PR request?

from ember-useragent.

• automatically install ember-cli-cjs-transform during the installation of ember-useragent

I could implement this as a stop gap until embroider-build/ember-auto-import#119 drops?

from ember-useragent.

@willviles you closed this ticket without providing a clear solution. But I an inferring from the linked ticket #27 that is still open that the "approved" solution is to just install ember-cli-cjs-transform as a project dependency, is this correct?

Will we still see it auto installed as an ember-useragent dependency in the future so we don't have to maintain yet another package in our projects?

from ember-useragent.

@lpaulger Correct. Ember UserAgent currently depends upon ember-cli-cjs-transform being installed in your project. I'm hoping there's a happy path forward with ember-auto-import very soon. I'll look into it ASAP, but in the meantime PRs are welcomed!

from ember-useragent.

I've created a branch for implementing ember-auto-import. Try it out:

npm i -D git://github.com/willviles/ember-useragent.git#ember-auto-import

from ember-useragent.