winworldpc / adventure Goto Github PK

This can cause a loss of context as some browsers do not allow the 'back' button to close the new tab.

When editing a download that already has multiple architectures selected (not just one), the architecture field show none selected, and any previous selections are lost if the record is saved without manually re-selecting them.

Tested in Palemoon and Firefox 52 ESR.

I think I've figured out the mirror and file scheme, as well as hooks for HL protection. The previous implementation was SQL based, but since we're no longer using a stateless framework, we can just hold everything in state when we un-nop protection.

When editing a Release, unchecking "show only year" and submitting does not change the setting.

This includes wiring up passport, an auth handler, and authing it against the database. I'm tempted to use HTTP Basic for authentication, seeing as we don't need to have SSO with the forums anymore.

Non-JS fallbacks are mandatory.

• Consider an inline Markdown editor and preview.

• Byte size fields should be enterable in larger-sized units, and then convert down to byte size for the sake of the UI.

• Instead of manually entering IDs, use a selection to drill down to product, and then if needed, release. Without JS, fall back to manual ID entry.

A lot of these are hardcoded.

Possible fix: restore the old one. It was glorgious.

Handle contributions, products, and releases management. Fairly soulless SQL work.

I can not select multiple Processor Architectures when editing a download.

For example, when editing "Microsoft Windows NT 4.0 Workstation (4.00.1381.1) [Korean] (ISO)"
https://winworldpc.com/sa/download/e160cb5a-5c3e-11e8-8d2a-fa163e9022f0

It is supposed to be x86-32, ppc, MIPS, Alpha

but when I select them and submit it says "The download can not be edited"

None of the download links on your website are working.

How do I install this for testing?

Send an email to the associated account, keep track of PW change requests.

Dear WinWorld staff,
We want YOU to host new servers below:
Storm (hosted in Prague)
Thunder (hosted in Belgrade)

See attached image. The page title Hello World! is showing up in addition to WinWorld's name and slogan.

https://github.com/expressjs/serve-favicon looks good for handling favicons, the apple stuff I can probably forward like I did to robots.

Perhaps look into programmatic generation of robots: https://www.npmjs.com/package/express-robots

Created a completely new product page: https://winworldpc.com/product/instant-accounting-98 but it shows me no buttons to add a new release or further edit the new product. I also don't see where it paced the product in the library (the page did not ask for category).

The search field's placeholder text already says 'Search'; there is no need for redundancy. It would make more sense to have the search button have an icon glyph of the magnifying glass (similar to Google's).

Longer term, but perhaps don't replicate the FTP based one? Obviously, hook into contribs table.

Whenever I click on a (any mirror) mirror to download weather it be Windows, Mac, or even Linux, it will just take me to WinWorldPC Library section.

Today, when I go to create a new download item under any product I get a generic "There was an error creating the item." error.

http://ogp.me/

• Upload screenshots

• Delete (and maybe the files?)

• Edit titles

• Reordering if it isn't a PITA to implement

Of course, the production password won't be password. Manage secrets (likely via env variables or gitiginored config file; with examples in docs) as well as have an easy way to deploy Adventure as needed.

On winworldpc.com, the homepage's title in the tab bar shows 'WinWorld: Hello, world!'.

'All software in our collection is archived in the 7-Zip format for optimal compression. 7-Zip is a free, open-source archival utility, and we recommend using it for extracting any files downloaded from our software library. The files enclosed will be of varying formats which you can read more about on our Archive Information page.'

On winworldpc.com, if I leave the search query field empty and hit 'Search', it just returns a blank page. Consider displaying a 'No results found' or 'Search query empty' message if this happens.

See: DRY. Reduce scope of SELECTs when needed.

Hi there, this is only a suggestion of something you could implement when you are completely done with the development of Adventure :)

Since Winworldpc is dedicated to old software, sometimes I have the need to download some program from it on an old computer that runs some obsolete browser and right now Winworld is completely unusable on this sort of machines, so I have to download it on a modern PC and then transfer it on the old PC.

Perhaps in the future you could add a "light" mode that would use minimal CSS/JS so as to be compatible with old and obsolete browsers like Internet Explorer 5? :-)

Alternatively perhaps there could be a way to directly access the files via FTP or HTTP, say after registering an account to prevent bots abusing the site, like it used to be in 2012 when you just had the default directory listing (I admit that it was a little bit messy and Adventure is much more organised)?

EDIT: I've seen another issue that was posted. Apologies for the double post :(

Thanks in advance :)

15:15 <~Duff> unrelated to the forums, but have you heard/looked at the checksum bug, I don't really consider it a huge priority
15:15 <@calvin> checkrums iirc are per-download
15:15 <@calvin> either MU was applying the wrong hash or someone applied the wrong checksum
15:16 <~Duff> are you sure, cause people are downloading them and they don't /match/ but they share a lot of similar characters
15:16 <~Duff> like i saw a SHA comparison
15:16 <@calvin> the DB table says sha1
15:16 <~Duff> only ~10 were out of place from the one shown on the site
15:16 <@calvin> but i wonder if it got changed it to sha256
15:16 <~Duff> hm
15:20 <~Duff> ---------------------------
15:20 <~Duff> Checksum information
15:20 <~Duff> ---------------------------
15:20 <~Duff> Name: Microsoft Windows 3.1 (3.10.103) (3.5).7z
15:20 <~Duff> Size: 6694673 bytes (6 MB)
15:20 <~Duff> SHA1: 6620162A6D54CDA13FE2DC0DDB2E9EDF909B37A3
15:20 <~Duff> SHA1: 6620162a6d54c38dc2a13fc3a2c39c0dc39b2eef
15:20 <~Duff> see
15:20 <~Duff> similar but not correct
15:21 <~Duff> (first is generated locally, second is from the site)

By deleting the readonly="" property on the text field, a determined user could edit the email address of their profile even if the system does not permit it. It would make more sense to hide the submit button in addition to making the text field read-only to prevent mishaps like this. See #46 for an example code change.

When browsing the Applications section, filtering by tags disables filtering by platform and vice versa. I'm not sure this is expected behaviour, so I'm filing this bug report.

https://winworldpc.com/product/warcraft

The winworldpc twitter feed overflows the window, causing scrollbars to appear on iOS. Screenshot coming soon.

Allow filtering on the library, and categorize them like before. Show screenshots on release pages, which were referenced in DB and stored in static content. Show releases by default.

"Whether you're doing looking to go down memory lane"
"entire library at no charge.WinWorld provides" (no space between charge and Winworld)

My knowledge of node.js is very limited, but I'd like to help in any way I can with the rebuild

The CSE results currently use Google's styles, and this clashes with WinWorld's Bootstrap CSS.

FULLTEXT sucks, consider Google Site Search.

Any plans making new winworld's style like old winworld?? I miss the old winworld... :(

When editing a PRODUCT, if I select more than one tag and submit, it returns "The product could not be edited." and the changes are not saved.

I'm guessing this is the same SQL bug that affected some of the other forms.

I'm trying to create an account so I can post a problem but once I fill out the form and click to create the account, the web server displays a dump that it could not continue.

Thanks

Cecil Bayona

Some thoughts on what we need:

• A way for users to point out corrections and broken items

• A way for users to request content

• A way for users to offer content (other than a future automated contribution system)

What we want:

• A way for users to ask about products/releases, and get help with them or share facts.

• A way for staff to post notices or longform articles to users

• A way to authenticate

A look at some solutions:

• Email works for offers, corrections, and site issues; but a poor fit for other things

• Twitter works for breaking site notifications and social media presence.

• A blog could work for notices and articles, but we'd have to integrate it into at least the visuals, and it doesn't handle any other case.

• Disqus embeds provide a nice solution for releases/products, and we can integrate it into our auth system, though it's a poor fit for anything other than product/release pages, and has issues scaling.

• A forum would get us back to where we were before, but the forum model has a LOT of issues and crappy software, IMHO. I'd like some way to integrate it into our theming and SSO. phpBB worked before, and the schema has everything needed to integrate with it, but I'd rather not maintain the horrifically broken DB or the fragile SSO system that was in place before.

  • A forum (or blog) could be rolled into Adventure, but I really don't want to increase the scope of it further - rendering static Markdown content might have been pushing it.

When I try to make a change to a download and click submit, I get this:

TypeError: req.body.arch.join is not a function
at /opt/winworld/adventure/adventure/saDownloadRoutes.js:100:50
at Layer.handle [as handle_request] (/opt/winworld/adventure/adventure/node_modules/express/lib/router/layer.js:95:5)
at next (/opt/winworld/adventure/adventure/node_modules/express/lib/router/route.js:137:13)
at /opt/winworld/adventure/adventure/node_modules/body-parser/lib/read.js:130:5
at invokeCallback (/opt/winworld/adventure/adventure/node_modules/raw-body/index.js:224:16)
at done (/opt/winworld/adventure/adventure/node_modules/raw-body/index.js:213:7)
at IncomingMessage.onEnd (/opt/winworld/adventure/adventure/node_modules/raw-body/index.js:273:7)
at emitNone (events.js:106:13)
at IncomingMessage.emit (events.js:208:7)
at endReadableNT (_stream_readable.js:1064:12)

Even if I had to code this completely by myself, how would I go about doing it? I'm not referencing any particular software, I just want a general guide (on how to create the page, config setting, EJS, etc.)

When editing an existing download that has an architecture of x86-32 already set, "x86" also becomes selected and will be saved unless it is manually deselected.

Likely bootstrap powered, consider changing template engine from EJS to something newer? Consider replicating the original layout as well.

I found no other place to report, so i will just do it here.

http://julian.winworldpc.com/download-test.php and http://bubbles.winworldpc.com/download-test.php look fine, but http://ricky.winworldpc.com/download-test.php states "From julian.winworldpc.com, your IP address appears to be: X.X.X.X" instead of "From ricky.winworldpc.com, your IP address appears to be: X.X.X.X"

Currently the CMS does not support old browsers, as far as i can tell. Using Firefox 2.0 for example, i can not see the navbar at the top. That support would be a nice addition, and if wanted, i can try to contribute on implementing it.

Now that we can reasonably call config from views, work on ripping out things like WW branding and analytics from views, and move it into config options and/or an includable file.