Comments (15)
Addendum to the above.
Also, the on and off hotkeys for the backpack modules do not work. But the modules themselves work, whether it's a magnet that attracts objects or a music block.
from accessories.
Will investigate such as I currently have another issue where the slot does not work at all.
from accessories.
I have tried to investigate issues with this mod but I am having issues running such in production and development. Combined with the fact to which they add trinkets compatibility makes it difficult to add proper support for such meaning it may not be fixed until they deal with such on their side.
from accessories.
If a backpack is worn on a backpack slot, the hotkey for summoning the backpack inventory does not work. Backpack from mod - Sophisticated Backpacks (Unoffical Fabric port). MC 1.20.1 and Fabric 0.15.11
same issue for me
from accessories.
If a backpack is worn on a backpack slot, the hotkey for summoning the backpack inventory does not work. Backpack from mod - Sophisticated Backpacks (Unoffical Fabric port). MC 1.20.1 and Fabric 0.15.11
any luck?
from accessories.
So I figured out why this bug happens.
It all comes down to this line: https://github.com/Salandora/SophisticatedBackpacks/blob/c7aa78dac052134b50c71b6a52884e1ed1b5080d/src/main/java/net/p3pp3rf1y/sophisticatedbackpacks/compat/trinkets/TrinketsCompat.java#L96
While trinkets returns a set of TooltipPredicates your compatibility layer does not.
Now I do think this is on my end as it should have been getValidatorPredicates to begin with, so I'll fix this.
That said I think this could still be considered a bug as it does not return the same values as trinkets does.
As further information TrinketInventory and SlotType are both instances of your Wrapped classes.
from accessories.
It all comes down to this line: https://github.com/Salandora/SophisticatedBackpacks/blob/c7aa78dac052134b50c71b6a52884e1ed1b5080d/src/main/java/net/p3pp3rf1y/sophisticatedbackpacks/compat/trinkets/TrinketsCompat.java#L96
Ngl that makes little sense why they use tooltip predicates as such should be for tooltip info not logical equipment checks. I could make a patch for this by routing the base predicates to all three method calls instead to fix this issue. Maybe something that can also be changed on the side of Sophisticated Backpacks possible
I need to read instead of skimming but I rushed without looking which is my bad, I agree that I should change the behavior of such to return the main set of validators for all three predicates method calls
from accessories.
Going to try something in development to see if such is the true problem and adjusting it to the other method call would fix such
from accessories.
After making the need changes it still seems to be have a problem which is quite odd... as in my environment I am unable to equip it in any slot.
from accessories.
Wait I might know what might be going wrong and its to do with the SlotGroup stuff. Sadly did not work and unable to get it working in prod still ):
from accessories.
If it helps I can offer to test your changes in my dev environment. With and without the fix I applied.
from accessories.
If it helps I can offer to test your changes in my dev environment. With and without the fix I applied.
I pushed the changes to the TCLayer and published such to modrinth and curseforge if u want to test such.
from accessories.
Sorry for the late reply.
The Accessories versions I tested were 1.0.0-alpha.24+1.20, 1.0.0-alpha.26+1.20 and Trinkets Compat Layer 3.8.1+alpha.12 and 3.8.1+alpha.13.
I tested with sophisticated backpacks dev(fixed version) and production(build.104/released version).
And the changes you made work in all versions perfectly for me, I can equip the backpack, open it with the key bind and disable the upgrades with the key bind.
from accessories.
Oh really.... hmmm I should retest myself
from accessories.
Oh yea it seems to be fixed. Closing such then.
from accessories.
Related Issues (20)
- [Bug] When a player attempted to access my server, his client crashed. HOT 2
- Server crashes after updating tclayer accessories Fabric 1.21 HOT 2
- Mislabeling of Curseforge upload HOT 1
- [1.21][Neoforge] Crash when add extra slot via config HOT 2
- [Bug] Dropped accesories on death - Incompatiblity with Revive HOT 14
- [Bug] Incompatible with the Affinity mod - Endec Version Issues HOT 4
- Sophisticated Backpacks GUI rendering incorrectly + Some items from Artifacts don't apply their effects. HOT 3
- Incompatibilities w/ spartan weaponry & simple hats HOT 20
- [Bug] Inconsitent Map equip action with Map Atlases [Forge] HOT 3
- [Bug] Null base amount crashing if add/subtract operation occurs before such being set HOT 5
- Always Visible UI HOT 1
- [Bug] Incompatibility with "Iron's Spells 'n Spellbooks" Curios Slot "Spellbook" [NeoForge 1.20.1] HOT 2
- [1.21.x][Neoforge] CC layer Beta7 causing game to freeze on launch
- Crash with latest versions, mixin inject failed HOT 3
- Crash - Spell Engine? HOT 3
- [Glitch] Invisible trinkets in multiplayer HOT 7
- Accessories + Curios Compat Layer 1.20.1 crash with Embeddium Extra or Radium HOT 1
- Create Engineer Goggles doesnt show overlays when equipped as an Accessory HOT 3
- [1.21] `AttributeModifier` with the Same `ResourceLocation` are deduplicated even across `Attribute`s HOT 6
- [Feature] Visual Slot indication HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accessories.