wisp-forest / owo-velocity-plugin Goto Github PK

PaperMC/Velocity/pull/1202

Plugin is incompatible with ReplayMod. Just telling "Server sent an invalid packet"

Issue

I am trying to connect to an All of Fabric 5 v1.3.1 (1.18.2 Minecraft) server from a Velocity proxy (with legacy forwarding, using FabricProxy and CrossStitch). OwO is installed on both the server and proxy side. Whenever I try to connect I get an ArrayIndexOutOfBounds exception, and upon investigation I determined this plugin to be the issue.

Solution(?)

I fixed this issue myself by changing OwoHandshakeHandler#onPreLogin(PreLoginEvent event) from:

conn.sendLoginPluginMessage(OwoVelocityPlugin.HANDSHAKE_ID, new byte[0], responseBody -> {

To:

conn.sendLoginPluginMessage(OwoVelocityPlugin.HANDSHAKE_ID, new byte[Short.MAX_VALUE / 4], responseBody -> {

After changing this and recompiling, my connection can now be established. I did not make this a PR, as I honestly have no idea the ramifications of doing it this way (how it would affect other MC versions, etc.), but this is how I fixed that issue in this specific case.

A friendly reminder regarding the issue raised in Discord
Current owo-velocity-plugin is compiled sgainst J18, so this needs a new release