wkeeling / ratelimitingfilter Goto Github PK

TypeError: unsupported operand type(s) for +=: 'ConnectionError' and 'str'

This project used to use Travis for CI, but should now be converted to use GitHub actions for running tests and deployment to PyPI.

Hey,
I've build an RPM package out of this repository for Fedora.

It is currently available in Fedora 27, Fedora 28, and Rawhide.

You can install with:
dnf install python{2,3}-ratelimitingfilter

Hey,
When logging just an numeric value, and rate limiting kicks in, a TypeError is raised, as the library tries to concatenate an int and str.

eg.

for x in range(100):
    log.info(x)

  File "/home/mnuttall/.pyenv/versions/3.6.5/lib/python3.6/logging/__init__.py", line 718, in filter
    result = f.filter(record)
  File "/home/mnuttall/.local/share/virtualenvs/catalog-ilphx365/lib/python3.6/site-packages/ratelimitingfilter/ratelimitingfilter.py", line 74, in filter
    num=bucket.limited)
TypeError: unsupported operand type(s) for +=: 'int' and 'str'

Otherwise, thanks for the lib 👍

Hi,

Nice library! I'm looking a way to setup a throttling that passes a record only once. Is it possible with your filters?

By using getMessage(), you are omitting any formatting parameter, this will cause an issue when the logger uses args

For example: logger.info("Example: %s", "text") will be rendered twice while the second time it will be something similar to
"Example: text" % ("text",)

In order to fix this, you only need to set record.args to an empty tuple

This looks like a useful library. Would you be willing to put it on pypi?