wkoch / debounce Goto Github PK

The example constructor for "Debounce Button With a Custom Delay and INPUT_PULLUP" shown in README.md is missing the third boolean argument.

In the readme, it appears that only if you put the 3rd variable in the Debounce Button(2,80,true) that it appears that the pull_down is default, where the default is true.

It might be best to change Debounce.h from
25 Debounce(byte button, unsigned long delay = 50, boolean pullup = true);

to
25 Debounce(byte button, unsigned long delay = 50, boolean pullup = false);

With the addition of the invert, the examples with a custom delay no longer work as this has become ambiguous. When a custom delay is wanted, I guess this makes the extra parameters required?

From one of the examples:
Debounce Button2(button2, 70); // Button2 debounced, custom 70ms delay.
This now generates an error:
call of overloaded 'Debounce(byte&, int)' is ambiguous

This would work though:
Debounce Button2(button2, 70, false, false);

Debounce Button1(button1, 30000,false,false);
//if delay is 30 seconds then led will turn on after 30 seconds but it will remain on for another 30 seconds after button is release.