wnet-ieg-2 / pbs-passport-authenticate Goto Github PK

Noted that there was a hard-coded link to a page that depends on a separate custom WNET-specific plugin to do member activation code lookups on the userinfo.php template. I've added conditionality so that link and text go to PBS's member lookup tool if the WNET-specific plugin isn't there, in commits 2cdef79 and 46d20f1 . However, the member lookup link should be configurable, in a plugin setting.

When using shortcode the button initially appears when the page loads and then disappears with the following error in the console:

Uncaught TypeError: Cannot read property 'status' of undefined
at updateUserLoginStatusArray (jquery.pids.js?ver=0.2.5.1:120)
at Object.success (jquery.pids.js?ver=0.2.5.1:95)
at i (jquery.js?ver=1.12.4:2)
at Object.fireWith [as resolveWith] (jquery.js?ver=1.12.4:2)
at y (jquery.js?ver=1.12.4:4)
at XMLHttpRequest.c (jquery.js?ver=1.12.4:4)
updateUserLoginStatusArray @ jquery.pids.js?ver=0.2.5.1:120
success @ jquery.pids.js?ver=0.2.5.1:95
i @ jquery.js?ver=1.12.4:2
fireWith @ jquery.js?ver=1.12.4:2
y @ jquery.js?ver=1.12.4:4
c @ jquery.js?ver=1.12.4:4
XMLHttpRequest.send (async)
send @ jquery.js?ver=1.12.4:4
ajax @ jquery.js?ver=1.12.4:4
retrievePBSLoginInfoViaAJAX @ jquery.pids.js?ver=0.2.5.1:88
checkPBSLogin @ jquery.pids.js?ver=0.2.5.1:83
(anonymous) @ jquery.pids.js?ver=0.2.5.1:243
i @ jquery.js?ver=1.12.4:2
fireWith @ jquery.js?ver=1.12.4:2
ready @ jquery.js?ver=1.12.4:2
K @ jquery.js?ver=1.12.4:2

Noted that if there's a hangup in javascript execution (external script resource taking a long time to load, etc), and the user who is logged in attempts to visit the login form, there is a possibility of the user getting bounced back and forth rapidly between the user info page and the login form page.

This is because the cookie/redirect check on the login form is on the client site, but the cookie/redirect check on the user info page is on the server side.

Should be easy to clean up.

In the file build-passport-player.php, on line 26, are two undefined vars, PASSPORT_ENABLED and $coveWindow. They appear to be placeholders for if the user is a member or not, but are never actually set anywhere.

@pdmytrewycz was having a failure running the plugin at all.

The default encrypt_method is AES-256-CBC and there isn't a place to set it manually. However, as noted in a recent comment on
https://www.php.net/manual/en/function.openssl-get-cipher-methods.php

"With OpenSSL 1.1.1 this no longer returns the uppercase variants of the name, i.e. AES-256-CBC no longer exists but aes-256-cbc does."

Documentation says there'll be an example of embedding a passport video.

It would look something like this:

`

Access to this video is a benefit for members of STATION

    <div class='pp-join-now'><a href='#' class='pbs_passport_authenticate_join button'>JOIN NOW TO WATCH</a></div>
    <div class='pp-label'>with</div>
    <div class='pp-logo'><img src='$passportlogo.png' alt='STATION Passport'/></div>

    <div class='pp-label'>Already a member?</div>
    <div class='pp-sign-in pbs_passport_authenticate cf'><button class='launch'>SIGN IN NOW</button></div>
    <div class='pp-learn-more'><a href='/passport/'>Learn more</a> about STATION Passport</div>
  </div></div>

`

and then you'd have some jQuery, like so

return function() { if ($("#passportcoveplayer[data-window]")[0]){ var active = 0; var videoWindow = $('#passportcoveplayer').data('window'); var videoID = $('#passportcoveplayer').data('media'); if (videoWindow != 'public' && videoWindow != '') { /* do nothing, not logged in, passport video */ /* jquery.pids.js takes over for passport enabled videos */ } else { $("#passportcoveplayer").html('<div class="embed-container video-wrap"><iframe id="partnerPlayer" frameborder="0" marginwidth="0" marginheight="0" scrolling="no" src="http://player.pbs.org/widget/partnerplayer/'+videoID+'/?chapterbar=false"></iframe></div>'); } } }

Hi William,

Our station was looking at a 'continue watching' feature for logged in users. Do you know, or have you explored, a possibility for this?

I don't think the MVault API allows for this, but I thought I would check and see if you knew of any options.

PS: My Apologies for submitting this as an 'issue', but wasn't sure of a better way to contact you.

I'd better add some example CSS.

one arg for class-PBS-LAAS-client.php is 'encrypt_method', which is defaulted to AES-256-CBC

This encrypt_method may not always be available. Or maybe someone wants to use a diffferent method.

It should be trivial to use the output of openssl_get_cipher_methods() to generate a select list and save this as a plugin setting.