Giter VIP home page Giter VIP logo

blossomspokemongomanager's People

Contributors

607ch00 avatar andyzen619 avatar armsdev avatar chilled-legumes avatar cleka avatar cryptically avatar dylanpdx avatar edysantosa avatar eralpsahin avatar fernandotbarros avatar fwdekker avatar kati3e avatar ljaysoft avatar marcelohenrique avatar michael-smith-versacom avatar naderki avatar selabie68 avatar stevenzeck avatar thecookiejar avatar u338steven avatar wararjey avatar weblue avatar westerlund avatar wolfsblvt avatar wullxz avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

blossomspokemongomanager's Issues

Config wrapper class

For easier access to settings, we need some abstraction between code and config.
I've done my first try on that with static methods in BlossomsPokemonGoManager.java but it's only for String atm.

@Wolfsblvt wanted to implement this :)

Settings window in application

I guess there will come more settings in the future that the user can control.
Sure, some can tweak config.json files, but we should consider usability. So there should be a settings menu where we will add all switches and settings and stuff that we will add in the future.

The window should be openable from the top bar.
Saving the settings depends on #36.

Search function truncation and "total highlighted"

Hi! Awesome work, wanted to leave a few bugs:

  1. Typing in "Pidgey" brings up Pidgey and Pidgeotto. Seems search is only taking the value up to "e" for some reason.
  2. When we highlight within the inapp cells, it'd be cool like in Excel / Word / Folder structures where we see at the bottom of a window, the status bar indicating how many are currently highlighted. This might be a dupe of another defect/enhancement where we're asking how many total Evolve's we've selected, etc.

Excel/CSV export of table

That shouldn't be such a difficult task, but it would be cool.

Just one button that exports the table as CSV, opens a file dialog and lets the user save it.

Needs update to new PokeGOAPI version

I'm currently porting the code to work with the new PokeGOAPI version 0.3.
They rearranged a bunch of the classes and added functionalities (using lucky eggs for example)

Handling Favorites

Favor/Unfavor Pokémon inside the list.
Display favorite Pokémon in the table (by column of color code) and make them sortable.

Original idea split from #42. Pinging @psentenac.

Session running out after a long period of time

When the application is open for a long time (sadly don't know how long), the session becomes invalid and the application will throw an exception when performing the next action:

[08/05 18:39:22]: D/RequestHandler: Authenticated with static token
[08/05 18:39:22]: D/GoogleUserCredentialProvider: 0
[08/05 18:39:22]: com.pokegoapi.exceptions.LoginFailedException: invalid_request
[08/05 18:39:22]:   at com.pokegoapi.auth.GoogleUserCredentialProvider.refreshToken(GoogleUserCredentialProvider.java:161)
[08/05 18:39:22]:   at com.pokegoapi.auth.GoogleUserCredentialProvider.getAuthInfo(GoogleUserCredentialProvider.java:234)
[08/05 18:39:22]:   at com.pokegoapi.api.PokemonGo.getAuthInfo(PokemonGo.java:111)
[08/05 18:39:22]:   at com.pokegoapi.main.RequestHandler.resetBuilder(RequestHandler.java:258)
[08/05 18:39:22]:   at com.pokegoapi.main.RequestHandler.internalSendServerRequests(RequestHandler.java:174)
[08/05 18:39:22]:   at com.pokegoapi.main.RequestHandler.run(RequestHandler.java:289)
[08/05 18:39:22]:   at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
[08/05 18:39:22]:   at java.util.concurrent.FutureTask.run(Unknown Source)
[08/05 18:39:22]:   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
[08/05 18:39:22]:   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
[08/05 18:39:22]:   at java.lang.Thread.run(Unknown Source)

@Ljaysoft wants this to be handled in the account manager.

very very useful , best currently

nice , simple , clean UI .

still , it would be awesom if we can use item such as incense/luck egg would also be great.

and should add:
pokemon list refresh button
should show candies if there's evolve button
totall pokemon's counts

Save sorting and column ordering, width and hiding

It's not connected with #43, this means something different here.

The sorting, and the column ordering too should be saved in the settings, so that on the next application start it will be restored. Also after every action in the app of course.
Also, there should be an option to hide columns, and somewhere to add hidden columns back. Also saved in the settings.

Important for the dev: If saving in the config.json, make sure that it's backwards compatible and will not break if a column is renamed, reordered or a new one is added.

Three suggestion for future things: Labeling system, Sprites/Images of Pokémon

I want to preface by saying, I'm not a developer: just a very active user. Many of these bugs and suggestions may have probably already been pointed out, but I want to help the project in any way a layman, such as myself, can. Here's what I've noticed in extensively using the 0.1.1 release:

Bugs:

-After a batch has been transfered/evolved/etc the sorting conventions reset, along with the order in which you had arranged the columns.
-Nidoran Male/Female Symbols look different than intended.

Suggestions: (The more pressing ones are first. Minor ones last.)

-Ability to Rename Individual Pokémon within the client.
-Labeling or Checkbox System. To label Pokémon "To Evolve Later" or "To Transfer Later." Perhaps some sort of simple hotkey for quick marking as you go down the list.
-Ability to toggle Favorite/Unfavorite Pokémon.
-Ability to color code a horizontal row to organize identify a Pokémon of personal significance.
-Option to show Sprites for each pokemon. It's minor, but it helps me distinguish between many rows of "Nidoran" and "Exeggute/Exeggutor," that look similar when you glance quickly at blocks of text.

Ex:
Exeggute
Exeggute
Exeggute
Exeggute
Exeggutor
Exeggute
Exeggute

-Column to sort by how long you've owned said Pokémon. Similar to the "Recent" Pokémon screen within the app.
-Column to sort by a Pokémon's "Maximum Potential CP" if it were to reach level 40.

None of these are glaring needs; just all things that I feel can help the program reach its full potential. Thank you all for your hard work and dedication. Love the product.

Translate Pokémon

I'm from Germany and need to look up the names for the Pokémon often. There is no need for other things to translate, but the names of the Pokémon.

Sort by multiple columns

Allow sorting by multiple columns, i.e. when choosing what to evolve or discard sorting by species, CP and IV would be very helpful

crashing after saving login info

Exception in thread "main" org.json.JSONException: JSONObject["login"] not found.
at org.json.JSONObject.get(JSONObject.java:471)
at org.json.JSONObject.getJSONObject(JSONObject.java:636)
at me.corriekay.pokegoutil.BlossomsPoGoManager.logOn(BlossomsPoGoManager.java:52)
at me.corriekay.pokegoutil.BlossomsPoGoManager.main(BlossomsPoGoManager.java:43)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:147)

Suggestion: Player info tab

Creating a player info tab with the information from the console that refreshes after an action and a lucky egg button/counter. Thoughts?

[Bug] Sorting

If I sort columns Lvl, Atk, Def, Stam, HP and to Evolve it's not sorted properly:
9
8
7
6
5
4
3
2
15
14
...

0.1.1 does not open

Windows 10, JRE 1.8.0_102-b14

Attempting to login via Google auth. After entering key, program does not show a window.

0.1 still seems to work just fine.

Issue with number of candies when evolving

Hello,

First of all, thanks for your great tool. It's everything i've been looking for.

I've spotted a minor error when evolving pokemons : In the "text" frame, there seems to be an issue when writting the number of candies to substract 👍
[08/03 17:49:43]: Evolving Rattata. Evolve result: Success!
[08/03 17:49:43]: Stat changes: (Candies: 40[-24], CP: 805[+505], HP: 72[+31])

It says 24 but Rattata takes 25 candies to evolve. Same issue with Pidgey where it says 11 instead of 12. I guess it will be the same for all of them.

Thanks again and keep up the good work !

Kargrim

DPS values incorrect

Move damage was updated on 29th of July, but the old DPS values are still being used. For example water gun got nerfed from 20dps to 12dps (15 dps with STAB).

[Suggestion] Add date caught column

Having a column for the date caught would be handy in sorting the day's catch while doing the first pass to transfer the majority.

I love the manager! I don't know how to implement this in the least but it was an idea I had while using it. Thank you!

HOWTO: Sorting by multiple columns

A trick for sorting that has existed for years is:
Pick your 3 columns, for example, you want to sort by, then sort them in reverse order - try it...
click on these columns:

CP
Move 2
Type 1

As it does the "next" sort, it keeps the sort order from the previous sort.

This gives you your Dex sort by
Type 1, and within that by Move 2 and CP inside that.

[Feature Request] Pokemon Level Column and Trainer Stats Window

Some initial impressions that I got from using this Pokemon Manager. You may already have some of these on your to-do list:

  • Display Trainer stats as a status field or its own box instead of a window (mainly for stardust)
  • Display Pokemon level as a field, upgrading without knowing the level is nearly useless although the required stardust field is helpful.

[Suggestion] After an action, sort is lost. Can u just update/delete the rows in the table

I know its simpler the way you do it, but if I sort on 3 columns and then work through my list, doing a simple Transfer makes me "lose my place" since you refresh the list. I have to resort and find where i was.

Also, I think its awesome the way you search... typing EEVEE finds the entire lineage, not just EEVEE. Nice touch.

Saw you guys on discord last night and am glad you got a new version out. very nice. WOOT!

Transfer confirm window is messed up

The transfer window scales as more pokemons are in the transfer list, but it's size increases too much that confirm button becomes out of reach. I had to rotate my second monitor portrait to be able to click it. Link here

(Bulk) Renaming using placeholders for table column values

I want to add an idea to the "renaming" feature.

It would be really cool if you can define how the name is set together yourself. I'll give an example. So the simplest thing would be to just use IV percentage, like magicarp_97. But for me, I really like to have the starting CP in the name, so that I can consider after I have evolved it if another pokemon would save me some dust if the IV is similar, cause it's CP is already higher. My current naming scheme is 590; 84.4.

Okay, long talk, short thing. Every person likes different names. How about generating the name from placeholders pointing at the table columns? So I would specify %cp%; %iv_percent% for my scheme. So it is also possible to use %species%, %id%, and so on.

Maybe it's a bit... overweighted my idea, but I would really love to see that.

TL;DR: Suggestion: Make renaming using placeholders for table column values.

Selection Checkboxes

Experienced this issue when selecting multiple Pokémon for mass transfer - misclicking deselected my 60~ selections.

Checkboxes in the rows for selection would make this more manageable and less mistake prone. Also included a select all toggle for easy deselection.

Make option to exclude families from search

When searching for Pidgey, it shows every Pokémon of that family, cause of the multi-search-bar. Sometimes that's not wished behavior.

We should add a settings toggle that can deactivate including of families from search. This toggle should be in the settings Window, so depends on #61.

Originally suggested in #56. Pinging @ISeeTanamon and @phronx.

Power-Up selected Pokémon x times

When powering up, make a slider or textbox to be able to set how often you want to power up that/those Pokémon.

Original idea split from #42. Pinging @psentenac.

Bug: Add check for existing saved credentials

If the credentials already exist, there's no reason to have the popup come again for saving. Automatically logging in based on saved credentials might also be a decent feature given that a logout function is added for players with multiple accounts.

Add collaborator names in Help window

Heya guys. @Blossomforth said that he wanted to add us as collaborators in the "Help" window and such.
Would just do that, but I guess it would be fair to ask everyone if he wants to be named there, and what name exactly should be written there. Some want GitHub usenames, others real names, etc.

Pinging @wullxz , @Ljaysoft , @weblue and @Wolfsblvt .

Settings for which columns should be displayed

I've noticed that many more columns are added and some of them are useful for my use cases and others not. That's why it needs to be possible to configure which columns should be displayed and which not. But I guess therefore we need to wait for #61.

[Suggestion] Items Tab

Add a tab for managing items in bag.

Features include:

  • Transfer/Delete Items
  • Activate Items (i.e. Lucky Egg, Incubator)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.