wonderkiln / flextabbar Goto Github PK

Hi wonderkiln Team,

I found 'WKAwesomeMenu' but 'open-tab-bar' does not exist.

Thanks
Sebastian

We are seeing cases of a double awakeFromNib() invocation of the WKTabBarController instance.
This causes a duplication of the container view, which in turn, might causes problems if you are relying on a particular view hierarchy for additional customisation.

There is a particular setup that might help reproducing this.
We have two segues that point to a WKTabBarController subclass on storyboards.
One storyboard contains the definition of the Scene and another storyboard uses a Storyboard Reference to execute a segue to that scene. The latter is the one that seems to trigger this double invocation.

A proposed fix is to introduce a nil check at the top of commonInit():

func commonInit() {
    if(container != nil){
        return
    }
    container = UIView()
    ...
}

error in WKTabBarController.swift

• 1- Error
  Argument of '#selector' refers to instance method 'didChangeOrientation' that is not exposed to Objective-C

NotificationCenter.default.addObserver( self, selector: #selector(didChangeOrientation(_:)), name: NSNotification.Name.UIApplicationDidChangeStatusBarOrientation, object: nil) if let vc = tabBarController(self, viewControllerAtIndex: 0) { changeViewController(vc) }
error:
selector: #selector(didChangeOrientation(_:)),

and

• 2- Error
  Contextual closure type '(_, WKTabBarItem) -> _' expects 2 arguments, but 1 was used in closure body

open func collectionView(_ collectionView: UICollectionView, layout collectionViewLayout: UICollectionViewLayout, sizeForItemAt indexPath: IndexPath) -> CGSize { let proportion = tabBarItems[indexPath.row].proportion let sum = tabBarItems.reduce(0.0) { $0.0 + $0.1.proportion } return CGSize(width: collectionView.bounds.width * CGFloat(proportion / sum), height: collectionView.bounds.height) }

error :
let sum = tabBarItems.reduce(0.0) { $0.0 + $0.1.proportion }