wordpress-mobile / wordpress-fluxc-android Goto Github PK

View Code? Open in Web Editor NEW

58.0 12.0 37.0 32.38 MB

WordPress Network and Persistence layer based on the Flux architecture

License: GNU General Public License v2.0

Java 28.46% Kotlin 71.45% Shell 0.09%

wordpress flux-capacitor persistence networking android library

wordpress-fluxc-android's People

Contributors

Stargazers

Watchers

wordpress-fluxc-android's Issues

Crash after tapping "Fetch first site" in the example app with a .org site

Test site was: https://dh.wpmt.co

java.lang.NullPointerException
  at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient.updateSiteFromOptions(SiteXMLRPCClient.java:144)
  at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient.access$200(SiteXMLRPCClient.java:27)
  at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient$3.onResponse(SiteXMLRPCClient.java:86)
  at org.wordpress.android.stores.network.xmlrpc.XMLRPCRequest.deliverResponse(XMLRPCRequest.java:52)
  at com.android.volley.ExecutorDelivery$ResponseDeliveryRunnable.run(ExecutorDelivery.java:99)
  at android.os.Handler.handleCallback(Handler.java:615)
  at android.os.Handler.dispatchMessage(Handler.java:92)
  at android.os.Looper.loop(Looper.java:137)
  at android.app.ActivityThread.main(ActivityThread.java:4745)
  at java.lang.reflect.Method.invokeNative(Native Method)
  at java.lang.reflect.Method.invoke(Method.java:511)
  at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
  at dalvik.system.NativeStart.main(Native Method)

Make SiteModel serializable

So we can pass it from activities to activities / fragments instead of an abstract "local blog id".

Support HTTP Auth on XMLRPC calls for self hosted

Add some correct usage notes to the README

None of the Model objects should ever be instantiated - they should only come by requesting them from their corresponding Store
Stores can be referenced directly, but only for read-only operations; all modifications must be done through Actions

AccountStore: new POST_UPDATE_SETTINGS POST_UPDATE_ACCOUNT action

Send modified settings / account to the server, not sure about the action names (POST_).

Implement site settings

This has been implemented in WPAndroid: wordpress-mobile/WordPress-Android#3568

Implement FETCH_POST_FORMATS action in the SiteStore

And store the array for post formats in SiteModel

Actions and the Dispatcher should only be used for external calls

We should use other events (not actions) and eventually a different bus for "wpstores confined actions" for instance:

FETCHED_SETTINGS, FETCHED_ACCOUNT, POSTED_SETTINGS, etc... (generally looks like callback not actions)

Crash in SiteXMLRPCClient when getting jetpack_client_id

FATAL EXCEPTION: main
    Process: org.wordpress.android.stores.example, PID: 2731
    java.lang.NumberFormatException: Invalid long: "null"
        at java.lang.Long.invalidLong(Long.java:124)
        at java.lang.Long.parseLong(Long.java:345)
        at java.lang.Long.parseLong(Long.java:321)
        at java.lang.Long.valueOf(Long.java:511)
        at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient.updateSiteFromOptions(SiteXMLRPCClient.java:145)
        at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient.access$200(SiteXMLRPCClient.java:27)
        at org.wordpress.android.stores.network.xmlrpc.site.SiteXMLRPCClient$3.onResponse(SiteXMLRPCClient.java:86)
        at org.wordpress.android.stores.network.xmlrpc.XMLRPCRequest.deliverResponse(XMLRPCRequest.java:53)
        at com.android.volley.ExecutorDelivery$ResponseDeliveryRunnable.run(ExecutorDelivery.java:99)
        at android.os.Handler.handleCallback(Handler.java:739)
        at android.os.Handler.dispatchMessage(Handler.java:95)
        at android.os.Looper.loop(Looper.java:148)
        at android.app.ActivityThread.main(ActivityThread.java:5417)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Make sure to pick the correct type for ids, specifically for media ids

Looking at the APIs doc and code, it's not obvious media ids are long or string. We should make sure to pick the correct type.

Add Plans in SiteModel / SiteStore

See https://github.com/wordpress-mobile/WordPress-Android/blob/1389eb2df5c0eea8e6913c547790c517a5d99652/WordPress/src/main/java/org/wordpress/android/models/Blog.java#L539-L553

New Demo Apps

Write some simple apps to demonstrate the ease of use of FluxC, for instance:

Instagram clone: login to a wp site + take a picture + filters + post image.
Live blogging app: kind of a messaging app for monologues, take/post photos, post short messages.
Stats app: basic stats for a site.
Twitter clone: unformated short message + local pics (+ location)

Crash when creating a new user

FATAL EXCEPTION: main
  Process: org.wordpress.android.beta, PID: 2272
  java.lang.NullPointerException: Attempt to read from field 'byte[] com.android.volley.NetworkResponse.data' on a null object reference
      at org.wordpress.android.stores.network.rest.wpcom.account.AccountRestClient$8.onErrorResponse(AccountRestClient.java:184)
      at com.android.volley.Request.deliverError(Request.java:590)
      at org.wordpress.android.stores.network.rest.wpcom.WPComGsonRequest.deliverError(WPComGsonRequest.java:49)
      at com.android.volley.ExecutorDelivery$ResponseDeliveryRunnable.run(ExecutorDelivery.java:101)
      at android.os.Handler.handleCallback(Handler.java:739)
      at android.os.Handler.dispatchMessage(Handler.java:95)
      at android.os.Looper.loop(Looper.java:148)
      at android.app.ActivityThread.main(ActivityThread.java:5422)
      at java.lang.reflect.Method.invoke(Native Method)
      at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726)
      at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616)

Apparently comes from an AppLog call.

SiteStore: it seems isAdmin is always false for .com sites

Instrumentation tests occasionally fail due to connection pool closing

I see this issue occasionally, when running instrumentation tests:

org.greenrobot.eventbus.EventBusException: Invoking subscriber failed
at org.greenrobot.eventbus.EventBus.handleSubscriberException(EventBus.java:505)
at org.greenrobot.eventbus.EventBus.invokeSubscriber(EventBus.java:487)
at org.greenrobot.eventbus.EventBus.postToSubscription(EventBus.java:416)
at org.greenrobot.eventbus.EventBus.postSingleEventForEventType(EventBus.java:397)
at org.greenrobot.eventbus.EventBus.postSingleEvent(EventBus.java:370)
at org.greenrobot.eventbus.EventBus.post(EventBus.java:251)
at org.wordpress.android.stores.Dispatcher.post(Dispatcher.java:46)
at org.wordpress.android.stores.Dispatcher.dispatch(Dispatcher.java:38)
at org.wordpress.android.stores.release.ReleaseStack_PostTestXMLRPC.uploadPost(ReleaseStack_PostTestXMLRPC.java:167)
at org.wordpress.android.stores.release.ReleaseStack_PostTestXMLRPC.testEditingRemotePost(ReleaseStack_PostTestXMLRPC.java:82)
at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
Caused by: java.lang.IllegalStateException: Cannot perform this operation because the connection pool has been closed.
at android.database.sqlite.SQLiteConnectionPool.throwIfClosedLocked(SQLiteConnectionPool.java:962)
at android.database.sqlite.SQLiteConnectionPool.waitForConnection(SQLiteConnectionPool.java:599)
at android.database.sqlite.SQLiteConnectionPool.acquireConnection(SQLiteConnectionPool.java:348)
at android.database.sqlite.SQLiteSession.acquireConnection(SQLiteSession.java:894)
at android.database.sqlite.SQLiteSession.executeForCursorWindow(SQLiteSession.java:834)
at android.database.sqlite.SQLiteQuery.fillWindow(SQLiteQuery.java:62)
at android.database.sqlite.SQLiteCursor.fillWindow(SQLiteCursor.java:143)
at android.database.sqlite.SQLiteCursor.getCount(SQLiteCursor.java:132)
at android.database.AbstractCursor.moveToPosition(AbstractCursor.java:219)
at android.database.AbstractCursor.moveToNext(AbstractCursor.java:268)
at com.yarolegovich.wellsql.SelectQuery.getAsModel(SelectQuery.java:151)
at com.yarolegovich.wellsql.SelectQuery.getAsModel(SelectQuery.java:144)
at org.wordpress.android.stores.network.HTTPAuthManager.getHTTPAuthModel(HTTPAuthManager.java:27)
at org.wordpress.android.stores.network.BaseRequest.setHTTPAuthHeaderOnMatchingURL(BaseRequest.java:33)
at org.wordpress.android.stores.network.xmlrpc.BaseXMLRPCClient.setRequestAuthParams(BaseXMLRPCClient.java:58)
at org.wordpress.android.stores.network.xmlrpc.BaseXMLRPCClient.add(BaseXMLRPCClient.java:43)
at org.wordpress.android.stores.network.xmlrpc.post.PostXMLRPCClient.pushPost(PostXMLRPCClient.java:324)
at org.wordpress.android.stores.store.PostStore.onAction(PostStore.java:319)
at org.greenrobot.eventbus.EventBus.invokeSubscriber(EventBus.java:485)
... 20 more

In this case the failing test was during a post test, but I've seen it happen with other instrumentation tests. The test was dispatching a PUSH_POST action.

I've gone many days of running integration tests without seeing this error, and then I'll get it a few times in a row. Usually running 'Clean project' solves it, but not always.

Switch from metaWeblog to wp XML-RPC methods

We're currently using metaWeblog methods in several places (getting posts, editing posts, creating new posts) that since have equivalent wp methods. We should switch over to wp where feasible (or document why we're keeping metaWeblog where not feasible).

Add xmlrpcUrl to .com sites

It's currently not fetched from the REST API.

AccountStore needs a SIGN_OUT action

that deletes all account infos (and auth token).

Collect all XML-RPC and REST API endpoints in enums

Read all action and event names and define a style in our README

Example actions:

FETCH_X - request fetch from the server
UPDATE_X - local change
REMOVE_X - local remove
DELETE_X - request deletion on the server

Example events:

onXRemoved(int n) - Keep X singular even if multiple X were removed

Support Self Signed SSL Certificates

AccountStore: VALIDATE_NEW_USER and NEW_USER actions

To let new users signup, see https://github.com/wordpress-mobile/WordPress-Android/blob/23d7d289e2c0b39d70008a6bddad8ce182eeb814/WordPress/src/main/java/org/wordpress/android/ui/accounts/helpers/CreateUserAndBlog.java#L112-L150

Make sure all DB calls are synchronized

Looks like this might be the underlying cause of #92. It seems that while all DB calls are transaction-wrapped and thus thread-safe, it might be possible that two concurrent calls to WellSql can lead to a situation where one completes and closes the thread while the other is waiting, causing an IllegalStateException (Cannot perform this operation because the connection pool has been closed.) when the second thread attempts to act on a closed DB.

It's possible that the problem is only applicable to tests (the instrumentation test thread has some threading limitations, e.g. a new Handler can't be started off the instrumentation thread). We'll need to test and find the extent of the problem.

Use "Background" or "Async" thread mode for onAction()

When we switched from Otto bus to EventBus in #61 - I thought the default mode was "Background" but it's actually "Posting". We might want to run all our actions in one (or multiple) background thread(s).

Add timezone to SiteModel

And fetch it from getOptions call. It's used by stats here.

add a maxImageWidth field to SiteModel

add a maxImageWidth field to SiteModel, I'm not sure if this field exists (and if there is a limit on .com sites).

Checklist before wpandroid integration

Attach payload information to actions

With the way Actions are currently structured, there's no simple way to know when calling Dispatcher.createAction if a certain action needs a payload attached, and what type the payload should be.

One idea would be to create an annotation that generates a ThingActionBuilder (working title) for every item in aThingAction enum. The annotation declares whether the item needs to be accompanied by a payload, and what type that payload should take. Then, instead of calling Dispatcher.createAction(ThingAction.FETCH_THINGS, arbitraryPayload), we would have to call something like Dispatcher.createAction(ThingActionBuilder.createFetchThingsAction(stronglyTypedPayload)).

Before sinking time into this, we could try manually creating ThingActionBuilder and make sure it would actually make things simpler/clearer.

SiteStore: VALIDATE_NEW_SITE and NEW_SITE

To allow users to sign up and create new sites. See https://github.com/wordpress-mobile/WordPress-Android/blob/23d7d289e2c0b39d70008a6bddad8ce182eeb814/WordPress/src/main/java/org/wordpress/android/ui/accounts/helpers/CreateUserAndBlog.java#L125-L137

Use a code formatter as gradle plugin

Eventually call it as a commit hook - so we won't have any formatting issues

Deal with network errors

We're sending generic events to the dispatcher, some of them can make network calls. Clients should subscribe to network (or other kind of) errors occurring if an event fails to emit a OnChanged() event.

Implement dangerouslyDeleteAllContent

We'll need to implement our own version of WordPressDB.dangerouslyDeleteAllContent as part of the sign out flow.

Improve XML-RPC endpoint discovery (including redirects handling)

Currently, HTTP>HTTPS (presumably also HTTP>HTTP) redirects are followed, but there's an issue when POSTing to XML-RPC: the POST isn't re-submitted, and a GET request is made instead, which results in a 405 error.

This is following HTTP guidelines, which try to limit cases of submitting multiple POSTs, or submitting POSTs to other URLs, without the user's explicit consent.

On WPAndroid we probe for the rsd file with GET first. We should do the same for Stores, as we improve XML-RPC endpoint discovery in general (see #4).

buildscript {
    repositories {
        jcenter()
    }
    dependencies {
      classpath 'com.github.dcendents:android-maven-gradle-plugin:1.3'
      classpath 'com.android.tools.build:gradle:2.2.0-alpha1'
      classpath 'com.neenbedankt.gradle.plugins:android-apt:1.8'
    }
}

apply plugin: 'com.android.library'
apply plugin: 'com.neenbedankt.android-apt'
apply plugin: 'com.github.dcendents.android-maven'

repositories {
    jcenter()
}

android {
    publishNonDefault true

    compileSdkVersion 23
    buildToolsVersion "23.0.2"

    defaultConfig {
        versionCode 4
        versionName "0.1"
        minSdkVersion 14
        targetSdkVersion 23
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
    lintOptions {
        warning 'InvalidPackage'
    }
}

dependencies {
    // Support libs
    compile 'com.android.support:appcompat-v7:23.1.1'
    compile 'com.android.support:support-v4:23.1.1'

    // WordPress libs
    compile ('org.wordpress:utils:1.8.0') {
        // Using official volley package
        exclude group: "com.mcxiaoke.volley";
    }

    // Custom WellSql version
    compile 'org.wordpress:wellsql:1.0.6'
    apt 'org.wordpress:wellsql-processor:1.0.6'

    // External libs
    compile 'com.squareup:otto:1.3.8'
    compile 'com.squareup.okhttp3:okhttp:3.2.0'
    compile 'com.squareup.okhttp3:okhttp-urlconnection:3.2.0'
    compile 'com.android.volley:volley:1.0.0'
    compile 'com.google.code.gson:gson:2.4'
    compile 'com.google.dagger:dagger:2.0.2'
    apt 'com.google.dagger:dagger-compiler:2.0.2'
    provided 'org.glassfish:javax.annotation:10.0-b28'
}

version android.defaultConfig.versionName
group = "org.wordpress"
archivesBaseName = "stores"

wordpress-mobile / wordpress-fluxc-android Goto Github PK

wordpress-fluxc-android's People

Contributors

Stargazers

Watchers

Forkers

wordpress-fluxc-android's Issues

Recommend Projects

Recommend Topics

Recommend Org