canvas-tokens's Issues
๐ Feature Proposal
Now style dictionary builds all files for all platforms at the same time, but we can make this build separated for each platform, language and token level.
Motivation
It will allow us to update only changed files instead of all.
Acceptance Criteria
๐ Feature Proposal
Motivation
Acceptance Criteria
๐ Spike
Canvas Kit Styling is bigger than we originally anticipated. It feels like it doesn't fit well in our current Storybook IA. This spike should help us answer:
- Where should styling documentation live?
- How should it be structured?
- What content should be covered?
- What are we currently missing?
Deliverable
Make a recommendation to the team on where Canvas Styling documentation should live, what content it should include, and how it should be structured.
๐ Spike
Mobile is looking to use our tokens package. We need to explore how we would build our tokens for Android & iOS comsumption
Questions
What are the requirements for Mobile?
What format do they need to ingest our tokens?
Can we make a new package canvas-tokens-mobile or do we need canvas-tokens-[andoid/ios] ?
Documentation
Create a plan on how we will release canvas-tokens-[mobile]
๐ Feature Proposal
Launch an alpha release of the new system color tokens
Motivation
provide early access to the new system color tokens
Acceptance Criteria
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Spike
Find CK actions that can be reused by canvas-tokens and how we need to change them to be able to reuse.
Possible actions:
- forward merge
- release to be composite
- major / minor release
Questions
- What action do we need to have for
canvas-tokens
?
- What actions from CK and CKA can we reuse?
- How do we need to change these actions?
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Feature Proposal
Add documentation to help consumers understand how to use our token packages in their applications.
Motivation
Good documentation makes it easier for consumers to use our tokens.
Acceptance Criteria
Add documentation for:
๐ก Suggestion
Developers need a guide to help them migrate from our old tokens in @workday/canvas-kit-react/tokens
to @workday/canvas-tokens-web
. Let's create a discussion for it.
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ก Suggestion
Token parser and sync script are both doing filtering and initial transform of tokens.
We need to validate if it's possible to combine them or have stricter understanding what they doing.
Motivation
It will make code base more understandable and cleaner.
๐ Feature Proposal
Add GitHub actions for pull request automation
Motivation
Run tests in CI to make sure everything is good before merging.
Acceptance Criteria
๐ Spike
Found a way to reuse our transformers to help consumers to generate files with tokens based on their json
Questions
Documentation
Existing Issues
๐ Feature Proposal
Add the next actions:
- lint-pull-request: to validate pull request title and structure (CKA action)
- new-issue: to add issue to backlog (third part action)
Motivation
Acceptance Criteria
๐ Feature Proposal
Motivation
Acceptance Criteria
๐ก Suggestion
The build, clean and release scripts need some adjustments.
๐ก Suggestion
Motivation
Example
๐ Feature Proposal
Motivation
Acceptance Criteria
๐ก Suggestion
We need to make a handful of developer-focused improvements to make canvas-tokens-web easier to use.
Motivation
Helping developers transition to the new tokens will reduce frustration.
๐ Feature Proposal
Add as const
to *.d.ts
files
Motivation
This will enable static parsing of styles as well as better type ahead support
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ก Suggestion
Publish our first version of @workday/canvas-tokens-web
Motivation
Let's get an initial release of Canvas Tokens Web out so we can test what works and what doesn't.
๐ Feature Proposal
Replace release action to canvas-kit-actions
repo and use it as composite.
Motivation
Less code for different releases.
๐ Feature Proposal
Add figma only tokens to filter to exclude them from config on sync
Motivation
Figma only tokens shouldn't be in the web token config
Acceptance Criteria
๐ Spike
Questions
Documentation
Existing Issues
๐ Feature Proposal
Add infrastructure to publish our tokens to npm and tag releases.
Motivation
CI / CD actions reduce opportunities for error and the cost of maintaining our tokens.
Acceptance Criteria
๐ Bug Report
Summary
The hex values for pomegranate 200 and berry smoothie 200 are incorrect.
Opacity 400 and 500 also need to be adjusted.
๐ Feature Proposal
Add Storybook for @workday/canvas-tokens-web
.
Motivation
Storybook allows us to organize and understand the output of our token transformations. It also creates an environment for our visual regression tests.
Acceptance Criteria
๐ก Suggestion
Motivation
Example
๐ Feature Proposal
Update our current PR template to match that we have in Canvas Kit
Motivation
We need a consistency across Canvas repos to have opportunity to use sharable GH actions
๐ Feature Proposal
Add forward merge action as we have for canvas-kit
repo
Motivation
It will be easier to keep branches up to date.
๐ Feature Proposal
- Update system.color.bg.muted.soft (licorice.200)
- Add system.color.bg.muted.softer (licorice.100)
- Add system.color.bg.alt.softer (soap.100)
- Add system.color.border.input.inverse (soap.300)
- Add system.color.fg.muted.soft (licorice.200)
- Add system.color.static.gold.stronger (toastedMarshmallow.600)
- Add system.color.text.primary.stronger (blueberry.600)
๐ก Suggestion
Motivation
Example
๐ก Suggestion
Motivation
Example
๐ก Suggestion
Motivation
Example
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Bug Report
Script PR has been merged before branch has been synched. Now it generates old version of main index files.
๐ Feature Proposal
Set up visual regression tests with Chromatic. This is dependent on #1.
Motivation
Visual regression tests will help us make sure we don't unintentionally break something while updating our tokens.
Acceptance Criteria
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Feature Proposal
Motivation
Acceptance Criteria
๐ Feature Proposal
Motivation
Acceptance Criteria
๐ Bug Report
The GitHub release action takes an incorrect changeset body to generate a release changelog
Expected Behavior
Changeset body is the same that we have for packages.
Actual Behavior
Use non modified text.
Steps to Reproduce
Web Release Action;
๐ Bug Report
The canvas-tokens-web
package.json
references "commonjs"
while the path is "common-js"
. This causes Jest tests to fail on a module resolution error.
๐ Bug Report
Expected Behavior
Actual Behavior
Steps to Reproduce
๐ Feature Proposal
We need to add workflow to merge PR by adding automerge label
๐ Feature Proposal
We need PR check action to be similar to what we have in CK.
Motivation
Acceptance Criteria
Action validates: