workday / escalar Goto Github PK

The Range Query currently has optional bound parms that could result in an empty query and also required ComparisonOp's that create funky method calls. We need to update the query so we pair the required parameters (ComparisonOp and Range value) and make the upperBound optional. This will result in a cleaner call to the query and a guaranteed result.

Using tags we can target which version of the client we build and which versions of Scala we compile against.

release issue

Escalar should support cross-building for Scala 2.10 and 2.11.

Essentially, this TODO: https://github.com/Workday/escalar/blob/master/src/main/scala/com/workday/esclient/EsQuery.scala#L332

TODO: version needs to be an Option.  If a doc id is not found, version is missing from the get response.
  * Today, Jackson is giving us 0 for version when the doc is not found.

Let's go update escalar to be able to use es5!
Now the question is...do we want to package this as a separate jar? or...right a separate class that extends from the Generic classes as specified in this pr: https://github.com/Workday/escalar/pull/7/files and essentially define what es5 client should be using these generic classes?
I vote for the former!

Add support for Exists and Missing queries.

Adding more extensibility will make it easier for others to use escalar for ES versions beyond 1.7 until we release and official upgrade.

We currently compile against Scala 2.10 and 2.11, we should add 2.12 to this so that new projects using 2.12 can also use our client.

The current implementation of the simple index API performs an update operation instead of a normal index op. This seems nonintuitive and could cause bugs for our users. We should change the implementation to call the proper ES API (and maybe move the existing code to a separate update method)

See:

• https://github.com/Workday/escalar/blob/master/src/main/scala/com/workday/esclient/EsIndexingDocs.scala#L51
• https://www.elastic.co/guide/en/elasticsearch/reference/current/docs-index_.html