workingrobot / craftimizer Goto Github PK

Hello!

To preface, my PC struggles to run FFXIV already. However, it gets much much worse every time I open the crafting menu because every single time I click on any item, it auto-opens the side bar and starts running a search for a suggested macro. I am not going to craft every item I click as sometimes I am just comparing recipies, or I already have a macro for the recipie.

Basically, I would apprciate the option to not run a show the suggested macro tab, and only show the "view saved macros/open in simulator" buttons.
My standard workflow is identify an item to craft, then open in simulator to run the search w/ increased control on what foods or HQ items I am going to use. Having the Suggested Macro run every time I open it is annoying, esspecially since there is no progress bar, so I end up just having to close the crafting log to get my game playable again. For refrence, FFXIV drops to ~7 FPS for around 30 seconds (with the easier crafts) when the suggested macro calculation is running.

If it is not possible to create a toggle for removing it, a toggle for adding a button to start it from that page would work as well. Just some way for it to not start automatically for every craft item.

Thanks!

still version1.2.1.0 in the client instead of the latest 1.9 version. cant update either

i checked every repo i have. nothing have craftimizer in the name. probably havent bumped it in official repo

Tried on almost all crafters.
Displayed LvL in Craftimizer is far lower than the actual class lvl.
LVL 90 CUL shows as either lvl 74 CUL (LVL 43 CLVL) Carpenter also shows much lower lvl. Love the tool sofar, never has crafting been easier.

Heya! Got craftimizer. I am a level 5 culinarian. Craftimizer doesnt refresh the level when i level up and says i have no actions available (but thats not true!) whats going on?

I noticed that the Synthesis helper does take the current quality into account when calculating its solution. Sadly though it doesn't seem to be able to recommend quality dependent actions for the current step, causing suboptimal solutions in certain situations.

I really enjoy using the solver but i noticed that it tends to recommend using a meld even though it could finish the craft with the remaining durability. As such i would appreciate if that minor flaw could be solved.

Version: v2.0.2.0

My friends and I would love to have the ability to tell the solver to attempt to have an X% buffer of quality to cover for bad poor procs and the like.

Description: Focused Synthesis is an action that increases progress at 200% efficiency with only a 50% success rate. When used after observe, its success rate is increased to 100%.

Issue: The synthesis helper often suggests to use observe, with Focused Synthesis visible immediately after it in the chain (something that makes plenty of sense, given that they're a combo), however, when using observe, the helper does not follow up with Focused Synthesis but rather suggests to use observe again, still intent on using Focused Synthesis afterwards. I think it understands that these two actions are combos, but the code doesn't run a check on whether or not observe was the last action/the combo is available.

I'm not very experienced with code, so take this all with a huge grain of salt, but I looked through it and it seems like you made some changes to Observe combo actions in this commit: 51e5f6e
In this same commit, you removed an if statement for observe that seemed to be a check attempting to prevent this weird loop from ocurring. Sometime in that period, you also changed FocusedSynthesis in the code as an accepted action to FocusedSynthesisCombo. I can't begin to pretend I understand how any of this works, but perhaps the former is still being referenced somewhere in the code, and this might've caused a thing to break?
I've also noticed that you released a fix for this same issue a month ago. I don't know if that didn't actually fix the issue, or if this is a new instance of it having been broken somehow else.

In any case, I hope you can figure out what's wrong. I love your plugin and I appreciate the work you put into it.

There is an option to turn off ignore manipulation in the macro, but there is no option to ignore Manipulation in the Synthesis helper, creating chronic issues trying to use it when you're leveling crafters that are high enough level, but have not unlocked it yet. Please implement a fix, or just disable Manipulation from the synthesis helper altogether.

Other than this, I love the work you have put into this. Thank you very much!

Hello, this project is great and has been really helpful! I have a question on the QoL side that if we can have an option to make all those windows separate and not attached to an in-game UI. I didn't find an existing settings related to this but I may be wrong.

Issue:
Macro generation seems to ignore iteration limit while missing seemingly simple ability sequence. Results in endless CPU utilization while the crafting log is open or while using the generate function of the simulator.

Screenshots:
Solver progress screenshot:
Runaway Screenshot

Working user created ability sequence:
Working Skill Order Screenshot

Settings: (Mostly default aside from the general tab and a reduced max core count to maintain system performance.)
Current Settings Screenshot

Tested settings and their impact: (All settings in the simulator tab were default besides the one being tested. General tab settings where the same as in the above screenshot. Each test was run for ~1m before being stopped manually)

• Algorithm [Oneshot, Oneshot Forked, Stepwise, Stepwise Forked, Stepwise Furcated]: No effect.
• Iterations [1000, 500000]: Both values seemed to have no effect. Both ran for ~1m before being manually stopped.
• Max Step Count [1-9]: (None of the values that were able to complete got close to completing the item.)
  • Beech Lumber stats: Durability = 40, Progress = 315, Quality = 2232, CP = 190
  • Lower values completed quickly but similarly failed to complete the item.
  • 7: Time = ~0m3s, Durability = 0, Progress = 0, Quality = 468, CP = 112
  • 8: Time = ~0m32s, Durability = 5, Progress = 68, Quality = 481, CP = 48
  • 9: Time = ~1m16s, Durability = 0, Progress = 0, Quality = 530, CP = 86
  • Higher values resulted in the seemingly endless iteration.
• Exploration Constant [0, 1, 4]: No effect.
• Score Weighting Constant [0, 0.1, 1]: No effect.
• Fork Count [1, 12, 32]: No effect.
• Furcated Action Count [1,16, 32]: No effect.
• Score Storage Threshold [0,1]: No effect.
• Max Rollout Step Count [1,99]: No effect.
• Strict Actions [on/off]: No effect
• Score Weights:
  • [P: 0.96, Q: 0.01. D: 0.01, C: 0.01, S: 0.01]: No effect.
  • [P: 0.85, Q: 0.01. D: 0.05, C: 0.05, S: 0.05]: No effect.

Notes:

• Equipped crafting gear was underleveled. Tools were around lvl 17 while gear was around lvl 50.
• Simulated manual synthesis of all lumber in the level 61 to 65 category was consistently successful (Difficulty 315 - 390).
• Beech Lumber, difficulty 315 level 61, was used for all testing.
• Birch lumber, difficulty 250 level 58, was the highest level lumber that a macro was able to be successfully generated for.
• Hallowed Chestnut Ring, difficulty 460 level 57, seemed to be the last non-lumber item that a macro was able to be successfully generated for. Though not all higher level items were tested.

System Info:
Plugin Version - v2.0.3.0
OS Name - Microsoft Windows 10 Pro
Installed Physical Memory - (RAM) 32.0 GB
Processor - AMD Ryzen 5 5600X 6-Core Processor, 4200 Mhz, 6 Core(s), 12 Logical Processor(s)

Other:
Thank you for the plugin and your time.

Not sure what is causing it since I had no issues before. The main difference being now versus before is that I am using Leatherworker and I am crafting Connoisseur Targe, expert reciper, and also started using Crafter Delineation mid macro creation. What happens is that I push an action button, seems to be random, and a second later the game crashes. Is the plug-in not compatible with crafter Delineation?