workspublic / tailor Goto Github PK

Tailor was developed against Postgres.app, which is easy to connect to. You don't need to supply your macOS username or password. It just works.

On Windows, the Postgres installer creates a Postgres user called postgres with a password postgres by default. Tailor doesn't currently provide a way to pass in a database username or password (nor any other database connection details). Adding this would ease the setup process for Windows users.

moverden wrote in on Discord that Tailor was only generating a single address match line and shared a screenshot. Looks like they are using full addresses (i.e. with city, state, ZIP).

Looking into this, noticed that primary address fields are accidentally hard-coded on these lines in the create table address_match_lines statement:

• tailor/lib/analysis/sql.js

  Line 94 in 4c907aa

  a.tailor_address_street,

• tailor/lib/analysis/sql.js

  Line 97 in 4c907aa

  where a.tailor_address_street = b.address_primary

Running a database server locally is biggish overhead for a sporadic analysis tool. Look into using SQLite + SpatiaLite + bundling dependencies, so that:

1. Tailor is easier to install
2. Tailor uses fewer system resources (i.e. Postgres isn't always on)
3. The database is easier to connect to (Windows users especially are reporting trouble with password auth, etc.)

Tailor uses ogr2ogr (npm package, not the GDAL tool) to load geodata. This requires systemwide GDAL to be installed, which can be a pain (especially on Windows).

There's a different npm package, gdal3.js, which has GDAL statically linked, so there's no need to install system software. Could this replace ogr2ogr?