Giter VIP home page Giter VIP logo

Comments (5)

petersandor avatar petersandor commented on May 21, 2024

That is indeed a good idea, but Program Files on Windows is mainly for 64 bit applications.
And from what I've googled, Blizzard introduced 64 bit client only in patch 4.3.2 (making this change irrelevant), see http://wowwiki.wikia.com/64-bit_client

Just as an example, I have 64 bit OS, but the client is 32 bit so it's installed in Program Files (x86) regardless. #windowsstuff

from wowser.

timkurvers avatar timkurvers commented on May 21, 2024

I was thinking of supporting OSX's /Applications/World of Warcraft/Data mainly.

At present we only support 3.3.5a though, would that change anything for where the client is to be found?

from wowser.

petersandor avatar petersandor commented on May 21, 2024

Yes, but only on Windows. As I mentioned, 64 bit software is located in Program Files and 32 bit stuff in Program Files (x86). These two directories coexist. #windowslyfe

So I think we should rather check for the OS type and based on that provide a default value (either Program Files (x86) or /Applications/World of Warcraft/Data)

from wowser.

timkurvers avatar timkurvers commented on May 21, 2024

Oh sorry, I always thought the folder was called Program Files (x64)!

Yep, sounds good! 👍

from wowser.

petersandor avatar petersandor commented on May 21, 2024

Implemented in #38

from wowser.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.