wswup / refet Goto Github PK

Hi,

The code says the wind speed unit is in miles per hour (mph) however, the documentation says it is in meters per second. What is the right unit for this?

If so, please change required parameters (hourly)

User may need to run the following to add the conda-forge channel

conda config --add channels conda-forge

The separate ".eto()" and ".etr()" methods are nice, but for some applications it would be easier to just pass the surface type directly to a method (instead of having a conditional in the application that picks which method to call).

Since it seems confusing to have "etsz()" and "_etsz()" methods, I think it might be easiest to rename the current "_etsz()" method to something like "_eq1()".

It would be nice to for the following functions to be accessible outside of the refet daily and hourly classes:
calcs._wind_height_adjust
calcs._ra_daily
calcs._rso_daily

It is fairly confusing having the latitude and longitude values be in degrees. There are checks in the code to see if the values are outside the expected range (i.e. [-pi/2, pi/2] for latitude), but it would probably be easier to just make the expected units be degrees.

The _etsz() methods in the Daily and Hourly modules are basically identical (G was removed in the daily one since it is 0). This could probably be done at the same time as #6 so that the function name could stay the same.