wulfy / alexa-homekit Goto Github PK

TESTS
New unit tests => to check regression
New functionnal tests => to test "in condition" with mocked data or real data

CODE REFACTO
Better understanding with separated object for Alexa mapping and domoticz data retrieving

https://github.com/wulfy/alexa-homekit/blob/master/domoticz.js#L109
=> remove "&"

https://github.com/wulfy/alexa-homekit/blob/master/config/domoticzCommands.js#L75
=> be more generic by using returned array "keys" to generate command.

https://github.com/wulfy/alexa-homekit/blob/master/AlexaMapper.js#L175
=> comment

https://github.com/wulfy/alexa-homekit/blob/master/AlexaMapper.js#L177
=> rename handleGetDeviceContextState

Alexa do not authorize special chars on friendly name and some of char on ID .
for now the string is filtered like this:

```

newDiscovery.discovery.friendlyName = newDiscovery.discovery.friendlyName.replace(/[^\w\s]/gi, ' ');
newDiscovery.discovery.endpointId = newDiscovery.discovery.endpointId.replace('.', '');
newDiscovery.discovery.endpointId = newDiscovery.discovery.endpointId.replace('/', '');

We should clean each part of the ID ("_") => split , clean, and then rebuild ID

For example:

• some description has unsupported char (\n, ", etc.) which can break JSON
• some IDs has unsuported char for Alexa (accents, spaces)

some debug logs save personnal user data in Amazon logs.
Even Amazon is secured, a data not saved is more secured :)

(check if those data are usefull or not)

json.txt

temp devices

to be more effective we have to set a CI on Amazon lambda

Find a way to configure tester (by CLI options and/or code options).

features:

• test alexa commandes with real calls to the client (database mocked object to force user data)
• test alexa commandes with fake client data (domoticz export used in domoticz mocked object)

Need 3 objects:

• 1 to mock Alexa calls for each known request
• 1 to mock domoticz requests and commands to force device status and device list answer
• 1 to mock the database to force user data to do real calls.

warning bumped by github

see client export