Giter VIP home page Giter VIP logo

Comments (9)

wumke avatar wumke commented on July 28, 2024

So you did not grant permission to make phone calls? In that case you need to handle yourself what will happen in your app and not call the library.

from react-native-immediate-phone-call.

bl1n0v avatar bl1n0v commented on July 28, 2024

@wumke, greetings!
Getting the same issue. Although I've granted the permission, double checked it with RN PermissionsAndroid module. What's the name of the permission? Is it CALL_PHONE or should it be something else (like PROCESS_OUTGOING_CALLS)?

from react-native-immediate-phone-call.

wumke avatar wumke commented on July 28, 2024

I never use latest latest react-native versions in my projects due to other library constraints... which version do you guy's use? Which android version/sdk? (I've tested it on android 4.4, 5, 6, 7, 8 so I don't expect this to be an issue...)

If you find relevant info about deprecated things in react native that might break this library please keep me updated in this issue-thread!

from react-native-immediate-phone-call.

somy001 avatar somy001 commented on July 28, 2024

Hi, I am having the same error. On my side, the error appears randomly, but mainly when developing my app. After a hot reload, I always have this error when making a call. I need to restart my app and then it's ok. I also had a client that encounter this error in a published version of my app, so it is not only after a hot reload.

from react-native-immediate-phone-call.

dbugshe2 avatar dbugshe2 commented on July 28, 2024

Hi, I was having this problem earlier, while running my app on an emulator, what worked for me was to turn off the wifi so as to fall back to using cellular, and for some reason (honestly, I don't know). it started to work again.

UPDATE: After a while (after live reloading, the error comes back again),

I think @wumke you might need to look at adding checks to all the places where you use reactContext and check to make sure you're not returning a null value. I'm not very experienced with java myself to handle it. Thanks

from react-native-immediate-phone-call.

wumke avatar wumke commented on July 28, 2024

If I find some time I will look into this...

from react-native-immediate-phone-call.

rcidt avatar rcidt commented on July 28, 2024

@dbugshe2 @somy001 @iNane-nane @khunghang16

My PR for RN60 support fixes this issue. Please merge, @wumke

https://github.com/wumke/react-native-immediate-phone-call/pull/35/files#diff-d7fbde4e2d2304704aab596064e3daa5R40

#35

from react-native-immediate-phone-call.

wumke avatar wumke commented on July 28, 2024

Can the ones having the issue confirm the PR changes fix all problems? Then I will merge it (No time to review myself at the moment...)

Thanks for contributing!

from react-native-immediate-phone-call.

dbugshe2 avatar dbugshe2 commented on July 28, 2024

Hi, So I've checked out the PR and tested it out in my app on an emulator.
did a clean via android/gradelw clean
and I didn't get the error at all even after live reloading multiple times(it usually crashes if I dial a number after a live reload)
but maybe someone should try it out on a physical device to confirm once and for all

but I'd say merge and close for now

from react-native-immediate-phone-call.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.