wvanbergen / active_olap Goto Github PK

When a date trend or time dimension is used and there is no data you get and sql error.
Line 65 of dimension.rb:
"CASE #{whens.join(' ')} ELSE NULL END AS #{@klass.connection.send(:quote_column_name, variable_name)}";

returns:
CASE ELSE NULL END AS "dimension_0"

Which is invalid. Might want to add a check for the "whens" variable on like 64.

If you run an olap query with a :joins, the 'id' column will be considered ambiguous. You need to prepend the table name to the front of the column for each dimension. In dimension.rb, line 58, add the @klass.connection.send(:quote_table_name, @klass.table_name) + '.' + to the beginning of the column name:

def to_case_expression(variable_name)
  if @category_field
    @klass.connection.send(:quote_table_name, @klass.table_name) + '.' + 
      "#{@klass.connection.send(:quote_column_name, @category_field)} AS #{@klass.connection.send(:quote_column_name, variable_name)}"
  else
    whens = @categories.map { |category| @klass.send(:sanitize_sql, ["WHEN (#{category.to_sanitized_sql}) THEN ?", category.label.to_s]) }
    "CASE #{whens.join(' ')} ELSE NULL END AS #{@klass.connection.send(:quote_column_name, variable_name)}";
  end
end

You'll probably want to implement a more robust solution though.

Hey Willem,

tried to use your plugin, but when doing on a simple model Ping, it raised an exception on

Ping.olap_drilldown(:created_daily => :period_1)

ActiveRecord::StatementInvalid: Mysql::Error: Unknown column '' in 'where clause': SELECT pings.* FROM pings WHERE (((>= '2009-11-22 00:00:00' AND < '2009-11-23 00:00:00') AND ((>= '2009-11-21 00:00:00' AND < '2009-12-05 00:00:00'))))

enable_active_olap do |olap|
# Easily create a trend dimension
olap.dimension :created_daily, :trend => {
:timestamp_field => :created_at,
:period_length => 1.day,
:period_count => 20
}
end