wxc318 / delphionrails Goto Github PK

Firstly, thanks for great work. 
I try to use websocket in my libriry, but i have no event.

constructor TMyClass.Create;
begin
  FWebS := TWebSocket.Create;
  FCtx := TSuperRttiContext.Create;
  FWebS.OnMessage:=procedure(const msg: string)
  var
    obj, ret: ISuperObject;
  begin
    obj := SO(msg);
    TrySOInvoke(FCtx, Self, 'ws_' + obj.S['action'], obj, ret);
  end;
  FWebS.Open('ws://echo.websocket.org');

procedure TMyClass.ws_echo(const value: string);
begin
  ShowMessage(value);
end;

procedure TMyClass.SendMessage(msg: string);
begin
  FWebS.Send(SO(['action', 'echo', 'value', msg]).AsString);
end;

When i send message from TMyClass.SendMessage, nothing happense.

Dephi 2010, Win7 x64

What's wrong in my code?

Are conditions and iterations supported? If not in DelphiOnRails, maybe there 
are known examples how I could use LUA for template scripting (HTML templates 
for example) with Delphi binding?

In our application, we stumbled across serious connection issues after updating 
DOR (client sends a HTTP GET, but the server answers with a rude TCP RST and 
ProcessRequest routines won't even catch the GET). We could isolate the error 
to the dorSocketStub.pas changes in r179 (using TThread instead of Windows API).

Some research shows that ignoring the deprecated warning for TThread.Suspend 
and TThread.Resume is fatal - using these can lead to freed memory being used, 
especially for applications using many threads. See 
http://qc.embarcadero.com/wc/qcmain.aspx?d=26291 for an official bug, 
http://stackoverflow.com/questions/1418333/tthread-resume-is-deprecated-in-delph
i-2010-what-should-be-used-in-place for a more broad discussion.

Also, from http://docwiki.embarcadero.com/VCL/en/Classes.TThread.Suspend:

"Warning: The Resume and Suspend methods should only be used for debugging 
purposes. Suspending a thread using Suspend can lead to deadlocks and undefined 
behavior within your application. Proper thread synchronization techniques 
should be based on TEvent and TMutex."

perhaps FReadTimeout should be FWriteTimeout,

function TRWSocket.Write(var buf; len, Timeout: Cardinal): Cardinal;
begin
  if (FReadTimeout <> Timeout) then
  begin
    setsockopt(FSocket, SOL_SOCKET, SO_SNDTIMEO, @Timeout, SizeOf(Timeout));
    FWriteTimeout := Timeout;
  end;

  Result := Winsock.send(FSocket, buf, len, 0);
end;

just learn dor, very excellent work.

kenter

The new WebSockets 06 handshake is much improved. It avoids the extra 8 bytes 
during handshake which causes a deadlock with proxies. Also, it uses SHA1 
instead of MD5.

Wikipedia has a nice summary of draft-ietf-hybi-thewebsocketprotocol-06:
http://en.wikipedia.org/wiki/WebSockets

Here's WebSockets 06 Protocol Specs:
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-06

ps

Your work is amazing: superobject, delphichromiumembedded and now I found 
WebSockets for Delphi in this project.  Thank you for making Delphi interesting!

In dorSocketSub.pas, TCustomObserver.ProcessEvents, an AV can happen similar to 
the one fixed in r234, TCustomObserver.TEventProcessor.Run. Change suggestion:

  procedure TCustomObserver.ProcessEvents;
  var
    Events, Event: ISuperObject;
    proc: TEventProc;
  begin
    Events := ExtractEvents;
    if Events <> nil then
      for Event in Events do
        if ObjectIsType(Event, stObject) and ObjectIsType(Event.AsObject['event'], stString) then
        begin
          if FEventProc.TryGetValue(Event.S['event'], proc) then
            proc(Event);
        end else
          doOnInternalEvent(Event);
  end;

Checking Event for nil shouldn't be required as ObjectIsType should take care 
about this case.

Passing strings containing empty values (like "[...]emptyparam=&[...]") to 
HTTPInterprete leads to a range check error.

Here's a workaround that works for me (dorHTTPStub.pas, line 231):

          if (i + 1) <= Length(S) then
            value := TSuperObject.Create(PSOChar(@S[i+1]))
          else // empty value
            value := TSuperObject.Create('');

When debugging or running an application using the IDE with range checking 
enabled, Delphi throws "range check error" exceptions because some of the 
results assigned to buf[] exceed byte range.

This change solves the issue:

    // reverse process of above
    buf[0] := (((Base64Map[data[i]] shl byte(2)) or (Base64Map[data[i + 1]] shr byte(4)))) and $FF;
    buf[1] := ((Base64Map[data[i + 1]] shl 4) or (Base64Map[data[i + 2]] shr 2)) and $FF;
    buf[2] := ((Base64Map[data[i + 2]] shl 6) or (Base64Map[data[i + 3]])) and $FF;

When closing a client connection, I often got Delphi exceptions in 
dorActionWebSocket.pas, TActionWebsocket.Output, line "Write(b, 1, 0);". It 
turns out that FStub.Source was nil, so perhaps checking FStub.Source for being 
nil would be good before attempting to call the Write method.

Same for the Write calls in TActionWebsocket.OutputMessage and 
TActionWebsocket.OutputStream (that one doesn't even have a try..finally around 
the Write call).

Amazing project, thnx,  should get more attention !!!

Delphi XE2 update 3 on Windows XP:

little typo i think:

when the server is running it says 

  writeln(' > EXIT   : Stop application.');

but it checks for lowercase

     if comparetext(Cmd, 'exit') = 0 then

When running our application in the Delphi IDE, we get range check errors at 
the following line of TRWSocket.Write:

  Result := Winsock.send(FSocket, buf, len, 0);

Disabling range checking in compiler options or using {$R} works, but doesn't 
feel good.

TRWSocket.Read receives messages byte by byte, changing it to

  Result := Winsock.recv(FSocket, buf, len, 0);

also leads to range check errors.

Unfortunately changing TRWSocket.Write to send byte by byte doesn't work, it 
seems to get too slow this way and break communication.

So, my questions would be:
  Is it possible that buf has to be passed to Winsock.recv/send different?
  What's the reason for receiving byte by byte, but sending at once?

What steps will reproduce the problem?
1. create a variable type tdatetime at class TBlog
2. edit view/blog/edit.html and add a field to the new variable
3. post the form, the value is wrong of the variable

I tried once, it looks good, but I have some Suggestions:
1, increase the session management capabilities
2, increasing the security check
3, add some other language platform client interface, such as basic4android

// I do not know much English

After cloning the source code I can not compile samples. Project files are 
missing madExcept, superobject, supertypes...
where to find them? or am I doing something wrong.

// I like the idea of creating DOR. I would like to be helpful