pe's People
pe's Issues
bug: inconsistency between user guide and application on uniqueness of internship
Description
- User guide states that if Company Name, Contact Name, Contact Email, Contact Number, Description and Application Status are all identical to an existing entry. When testing, it is possible to add another internship that is defined to be duplicate
Steps to reproduce
- Run this command:
add /com Google /desc test /status to_apply /poc Test Name /email [email protected] /phone 99999999 /role Frontend Intern
- Run this command:
add /com Google /desc test /status to_apply /poc Test Name /email [email protected] /phone 99999999 /role Backend Intern
Expected
- Duplicate internship errors thrown
Actual
- Command is ran successfully
Potential Suggestions
- Tighten duplicate person check logic
Screenshots
docs: insufficient examples for quickstart installation
Description
- By tp constraints, CareerSync should be platform independent, which include linux
- In the installation section of quickstart, only instructions for Windows and MacOS is provided to start CareerSync.
Steps to reproduce
- nil
Expected
- Steps to start CareerSync included for all major operating systems
Actual
- Instructions for linux left out
Potential Suggestions
- Add instructions to how to start CareerSync on linux
Screenshots
bug: unnecessary compulsory fields for add command
Description
- As many computing students apply for internships, most the applications don't go through a recruiter (apply through company job portal for example). Hence, making
CONTACT_NAME
,CONTACT_EMAIL
compulsory can make the app harder to use and potentially less helpful.
Steps to reproduce
- Run this command:
add /com Netflix /desc test /status to_apply
Expected
- Add command only need company and status as compulsory fields
Actual
- Contact name, email are compulsory and running add commands without them will be rejected
Potential Suggestions
- Make contact name and email optional fields
Screenshots
bug: contact_name field restriction inconsistency between user guide and application
Description
- User guide stated that
CONTACT_NAME
allows the use of any text, number or spaces. Use of any text should potentially imply no restriction on the character set permitted to beCONTACT_NAME
. This behavior is different from the application.
Steps to reproduce
- Run this command:
add /com Apple /desc test /status to_apply /poc test_na me /email [email protected] /phone 99999999
Expected
- Success
Actual
- Command reject with error: Names should only contain alphanumeric characters and spaces, and it should not be blank
Potential Suggestions
- Update user guide to list the restrictions of CONTACT_NAME or remove validation checks
Screenshots
bug: application desync and data lost when running more than 1 instance of CareerSync
Description
- When running more than 1 instance of CareerSync (running the app from 2 terminal sessions), can cause the app data to de-synchronized and lost.
- As an experience command line user, it is normal to have multiple terminal windows open or tmux windows. It is possible that a user can accidentally open 2 instances of the app.
Steps to reproduce
- Open 2 terminal session and each run
java -jar <jar_file>
- On each instance of the app, run any valid add command
- One of the internships added will potentially not be saved
Expected
- Both internship entry should be saved
Actual
- Some internship entry data is lost
Potential Suggestions
- Add warning message when more than 1 instance of the app is launched
Screenshots
- nil, lost of data
bug: email format inconsistency between user guide and application
Description
- User guide stated that:
The local-part should only contain alphanumeric characters and these special characters: +_.- .
- However, when adding a contact with emails that has consecutive "." (e.g.
[email protected]
), the email is rejected.
Steps to reproduce
- Run this command:
add /com Google /desc test /status to_apply /poc Test Name2 /email [email protected] /phone 99999999
Expected
- Success command execution
Actual
- Command rejected due to invalid email format
Potential Suggestions
- Update expected format of email in user guide or email validation logic
Screenshots
docs: inconsistent field name in user guide
docs: page number absent
Description
- As stated in the tp website, user guide
- Page number is useful when pointing any computing students to find answers to their problems.
docs: fields of command arguments is not explained in the fields summary
Test
test
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.