The css build output includes a reference to the node_modules directory which results in an error when included, at least when not using the library via module exports/imports.

Awesome work here. I don't see a pop up when highlighting in Firefox. Not sure if you tested there or not.

For websites in languages other than English, or in multiple languages, these are the only two reminders that this plugin is strictly localized. I believe the email is still very understandable without these prefixes, especially if it's broken down into paragraphs ( #22 ).

The sharer only closes if you click on a targeted element, not if the selection loses focus by clicking on an element that is not targeted by selection-sharer.

As a fix, I use:

if(!window.getSelection().length) {
    self.hide();
    return;
}

in this.selectionChanged, line 311, before checking self.isMobile.

Last version tag is from 2 years - could you update it? Moreover, I can't install plugin with npm, because it doesn't find files in npm registry. I can install it with bower, but downloaded version is very old.

Would love to have a .scss file included so I can import into my projects. Currently I copy the .css file out and change the extension to .scss. Having the .scss included in the distribution ensures that I'm using the latest version.

Thanks!

First of all, thank you for this module you made! It's wonderful. I wonder how to make it work in IE 9 please.

Thank you very much for your help!

Cheers

Tried the new Facebook code, and even though I have og tags it still shows me the message: "This page does not have a valid Facebook Open Graph Meta tags". You've seen this happening as well?

I would like to make the selection sharer translatable. Do you have any preferences about how this sould be done?

I actually need this feature for Drupal, where we must wrap the strings into the function Drupal.t().

To make the feature available also for other environments, I would suggest something like this:

if (typeof(selection_sharer_gettext) === 'undefined') {
    var selection_sharer_gettext = function (string) {
        return string;
    };
}

So, everyone using a translation framework can wrap it into this function.

Would you accept a pull request for adding custom UTM parameters to this? I'm looking at adding this to a new blog through @jcvangent's wordpress plugin, and I could see that being a super useful feature.

Thanks!

On iOS8/9 the contents below the p get pushed down but the menu does not appear.

I found that I was dissatisfied with the way the Facebook sharer uses the selected text to populate the caption element of the sharer dialog box instead of the larger, bolder description element. I have modified the code as below and would be grateful for your feedback.

dm-coding/selection-sharer@55e8ad6...djcf:56a33d63dbe01887cbd8b2209ef856ec0bdd9558

The most relevant lines are 243 and 245.

See here: http://progressorg.webflow.io/articles/reclaiming-our-land-and-water-michigan-and-the-world

Hi,

An error occurs running the code on certain websites. For example, when we run the code on www.example.com:

On the chrome console: 'Range.detach' is now a no-op, as per DOM

Select text, then scroll. The menu won't stay tethered to the selection.

For example I highlight a text in elements I've chosen, popup shows and if I click outside (for example on background), text gets de-selected but popup remains.

The popover box did not appear when I highlight. I suspect that this has to do with IE not reading the background-image properly.

Add a possibility to use custom share texts for email (and subject!), twitter etc.
Only possibility to change it now is to modify plugin directly.

clicking on a twitter,facebook, or email share prints the following special characters before and after highlighted text:

“

and I cannot figure out how to solve this. Thank you

The behaviour of Medium makes the popup appear when you select only one word. It's possible to adjust this plugin to do the same?

Thanks

Sorry, haven't been following this project and I just realized it had all those stars (thank you!) and issues ¯_(ツ)_/¯

Happy to hand it over to someone else who would have the time to maintain it.

Let me know!

Presumably to the demo on the blog, or to the GitHub page.

Example:

I would like to have the possibility to change the default popover twitter/mail share, and have another cumtom template in place, is there an easy way to achieve it ?

Add a configurable selection length (min/max selection size).

When you select downward text that comprises multiple lines, the Y coordinate of the context menu is at the beginning of the selection. The X is correct.

@molily's component doesn't suffer from this problem (demo).

When having a post which is written in Chinese (so all characters are Chinese) the pop-up doesn't appear to be popping up. Anybody seen this behaviour as well?

Hi,

I build a module wrapper in Drupal, you can see it in: https://www.drupal.org/project/selection_sharer

Thanks : ))

I'm working on a wordpress plugin of this (both because I can use it and it was in your README).

It's not finished, but it's here: https://github.com/Camwyn/wp-select-sharer if you want to see it.

The email text doesn't contain any line break to separate the quote, the title and the URL. These should be separated by at least one blank line to ensure legibility.

The "Email" link has an SVG inside with no text value, nor does it have an aria-label attribute to it. This causes accessibility issues.

Proposed PR: #79

i just installed this on Wordpress, selection shows sharing on twitter, email and linked in but not Facebook

How can i replace Linked In by Facebook?

https://www.infolibertaire.net/

Hello,

I am working on including your great script to an extension for a CMS.

This CMS allows me to add JS and CSS - but always to the heading of the page.

If I do $(function() {$('p').selectionSharer();}); the popover appears and lets me share via twitter and mail - but the script does not recognize the Facebook App tag.

As I can not hack the CMS, I have to find a workaround for this script.

Any help is highly appreciated.

Don't show the select text to share. Show only the URL config on fb:ID and not the select text of page.

Thank you for the great tool.

When selecting from right to left, the context menu is placed farther from the mouse position.