xelita / angular-basic-auth Goto Github PK

See, for example, here.

Hi,

I noticed that the base64 encoding in your module is not correct.
your code :
var authData = base64Service.encode(username) + ':' + base64Service.encode(password);

should be:
var authData = base64Service.encode(username + ':' + password);

After this change it worked very well, thank you!
Greetz,
Alfred

Hi,
A couple of months ago there was an improvement with the base64 encoding. But now your dist is out of sync with the sources.
Can you please build it again, so that if I do a bower install the base64 encoding is correct?
Thanx!

$http.defaults.headers.common.Authorization = basicAuthConstants.basicHeaderPrefix; fails because it sets the header with "Basic " (observe extra space). Safari doesn't like this.

See also here.

If you want, I can fork and fix it myself.

Use case: I have an API where I need to send a basic-auth header on every call, but I don't necessarily need to do a separate GET/POST to login/logout. In this case, it would be useful to have a function that sets the headers and one that clears them. Alternatively, one could check if url is null and skip the $http call.

If you find that this feature makes sense, I can create a PR.

It's quite outdated: for example, the header generation example still uses the wrong format encode():encode().