xentek / dm-postgres-types Goto Github PK

View Code? Open in Web Editor NEW

8.0 8.0 14.0 198 KB

Adds support for PostgreSQL-specific datatypes to DataMapper

License: MIT License

Ruby 100.00%

dm-postgres-types's People

Contributors

Stargazers

Watchers

Forkers

akemrir zaiste roll20 primerevenue litographs daanzu sharecrest pavels reefab berkes amasses

dm-postgres-types's Issues

pg_json.rb requires dirty_minder but doesn't use it

Unless I'm mistaken (always possible :) ) it also needs:

include ::DataMapper::Property::DirtyMinder

Storing and reading JSON is asymmetrical unless load_raw_value is true

When not using load_raw_value for a property you still need to serialize the value when setting the property even though you can read it as a Hash.

This is confusing since it is asymmetrical.

When load_raw_value is false I would expect that both reading and writing to the property to behave like accessing a Hash.

Search by json field

Can I do any filtration by PgJSON field? Now I get error like this:

"...dm-do-adapter/adapter.rb:147:in `execute_reader': ERROR:  operator does not exist: json = unknown (DataObjects::SyntaxError)
LINE 1: SELECT "id", "data" FROM "tests" WHERE "data" = 'value: 1' O...
                                                      ^

Here I tried search by field 'data' from your example: Test.all(:data => 'value: 1')

If not, where can it be added?

The error message for PgNumericArray notes that scale must be greater than or equal to 0 (ArgumentError). However, the code checks for scale <= 0, which excludes 0. It should be scale < 0 instead.

Recommend Projects