I want a complete list of globals that are in the xero namespace, as well as a description of what they do, or a link to relevant documentation. This could be in an appendix or something.

The function reset doesn't work with get, ie it doesn't set the values to their defaults.

funcs currently don't work with mode = 'end'.

ScreenReadyCommand was added in NotITG 4.2.0 and the Mirin Template doesn't currently take advantage of it.

I think the current way to make node/definemod player specific/limit is odd,
this is a proposed change that may make it better.

-- current syntax
definemod{'mod',function(mod,pn)
    if on <= 4 then
        -- code
    end
end}

-- suggested syntax
definemod{'mod',function(mod)
    -- code
end,
plr = {1,2,3,4}}

In most cases, if you make a typo in the name of a mod, NotITG will inform you that something is wrong, because it will attempt to apply an invalid mod. However, since ApplyModifiers gets parsed through strings, the spaces are silently ignored, and it gets very difficult to debug what went wrong. I would like the game to throw an error if there are spaces leading / trailing the provided mod names.

a reset(beat) function which sets mods to their default values, and a corresponding exclude global to control which mods are exempt from the reset

A way to add to the end of a table instead of specifying a specific number?
For people who don't want to make actorpool tables using :GetChildren, but want to copy paste actors directly instead of them all needing a different number in their name.

I'm not sure whar the syntax should be, but the options are probably these:

1. Name="in mytable"
2. Name="mytable[next]"
3. Name="mytable[#]"
4. Name="mytable[#mytable + 1]"
5. Other
6. None, but a doc page pointing to calling :GetChildren on an actorframe containing your pool

rrwoods:

i realize this isn't possible with the way mirin works, but it would be nice if, whenever mirin was headed into an ease that was linear, it used an activation rate instead of frame-spamming

Change with1param and with2params so that a metatable isn't created each call. create the metatables ahead of time.

While creating a song for the upcoming tournament, I encountered a situation where I was receiving a negative p in a func ease. I don't have time to debug this now.

I want to make the engine be able to support late queued eases, but behind a warning of some sort to the user. Maybe I'll have a "rooted" version of the mirin template that takes away the error messages lol

Apparently this has the potential of allowing things to run a frame earlier? I need to test and also ask @HeySora about this

I didn't put a bunch of effort into the error messages, so I think they should all be looked at and potentially rewritten to add more context and guidance. Maybe some should link to the docs. Maybe some should include docs. Maybe some should suggest asking for help in the Discord. I'm not sure what would work best, but I'm sure that what's in the template now has room for improvement.

right now you don't get a good error message if you call ease inside of a perframe.
I'd like that error message to be good.

A common use case is to have a mod instantly jump up to value, and then ease back down to its initial value. In Exchwasion's template, you could put the percentages as 100, 0, but in the Mirin template, you can only put in one mod percentage. Because of that, it takes more lines of code in the Mirin template than in the Exschwasion template.

The plan is to add a flip function that can modify an ease, creating a transient ease.
Here's how it would look like in use

ease {0, 1, flip(outExpo), 100, 'invert'}

Thanks to tari for pointing this out.

Currently, xmod and cmod are set in a separate applymodifier to each thing

I wanr to make a way to create non-player-specific definemods, and change the way definemods work to be more intuitive (potentially a different aux system).

Making this change would require rewriting the whole node system, whicj I want to do anyway.

Might get solved by #27, but the problem is that the speed mod is visibly set to 1x before the song starts, which is not great

The function func is getting extremely overloaded.

	local valid_func_signatures = {
		['number, function'] = true,
		['number, number, function'] = true,
		['number, number, ease, function'] = true,
		['number, number, ease, string'] = true,
		['number, number, ease, number, function'] = true,
		['number, number, ease, number, string'] = true,
		['number, number, ease, number, number, function'] = true,
		['number, number, ease, number, number, string'] = true,
		['number, string, ?'] = true,
	}

It would be a good idea to give each of these separate names

There should be a function that makes it easy to kick users back to the song wheel with a system message.
Suitable for messages like "This song needs to be played in 2 Player Mode", or other situations where a crash isn't warranted, but an error has occurred.

ie alias movex0-3 to movex1-4

definemod {'videogames', 25, 'flip', -75, 'invert'}

as shorthand for

definemod {'videogames', function(p) return 0.25 * p, -0.75 * p end, 'flip', 'invert'}

it's not but it should be

I think .lua is nicer because of editor support and user sanity. I want to switch as many files from .xml to .lua as possible if it doesn't make heysora mad.

right now, setting the noteskin leaves the template in an invalid state

During a breaking change, some functions can be renamed. I'm not completely sure which ones should be renamed, but, for example, node is an uninformative function name.

I want to put this out under some permissive license, but haven't gotten to it yet

that calls them both. Would hopefully be an easier way for people to learn node

For the first half of the ease it is out, and for the second half of the ease it is in. Can be pretty good for moving things on and off screen smoothly.

So, the square ease from my old template isn't in this template. There's a good reason: it is less efficient than just emulating the behavior with two instant eases. However, typing two instant eases is kind of a pain, so it would be nice if there was a helper function that could add both the entries at once. Maybe this would be better suited for a plugin than the official template. I haven't decided yet.

Plugins is kind of an undiscoverable feature in the Mirin Template. Imagine if that could be better.

By passing in a number where a string is expected, it's possible to reach this error message, which doesn't tell the user what they're doing wring:

/template.xml:74
attempt to get length of local `name' (a number value)

Found by Daikyi! Thank you very much!

Reportedby mirin:
Starting proxy code needs

P1:hidden(1)
P2:hidden(1)

or else the Yeah's and NG's from the original players will still appear.

persist=true, persist=false, persist=7, etc.

A persist value provides the template with a hint as to when to skip executing the function.

using funcs with eases like pop, bell etc. will not reset their values after finishing the ease
example I used: func {0, 4, pop, 10, 'bg:rotationz'}
this goes from 0 to 10 and again 0 after a short while but once at beat 4 this will snap back to 10, despite that this was not the previous rotationz given (it was 0, so it was never changed before this)
this also applies with normal funcs (the one that you pass a function() to instead of a string)

NotITG has a quick reset feature that quickly restarts the current song. Under some conditions, the mirin template doesn't play mods properly when that feature is triggered. https://clips.twitch.tv/EntertainingSucculentNigiriPeanutButterJellyTime-Kc8kMCneStSdJBIk
Twitch

You forgot to make a variable for math.abs for tri and spike ease to work. Just lettin' ya know.

This is suggested by TaroNuke.

Have a way to read the "current" value of a mod during the LoadCommand, instead of just having mod values being accessible in perframes/nodes.

"@XeroOl my code errors any time there are overlapping func easing calls, where before it would just disregard the first ease and start doing the next one"

Some eases aren't listed and don't have graphs. Those are the ones with the cache functions. I'd like to have a js implementation of those eases with scroll bars so that you can play with the curve in browser in the documentation.

Time based mods are affected by visualoffset and globaloffset and stuff, and are a pain to use. Mirin Template relies on a consistent timeline for all its timings, and currently does that by converting all beats to times before playing.

It's probsblu not going to happen, but I should at least consider the tradeoff between keeping and dropping time mod support

There's some parts of the documentation that's just labeled TODO. This should be replaced with more complete documentation.

thank you to Rya for finding this!

SetDefault may also ignore aliases.

I haven't had any functions in the mirin template for combining multiple eases together, but why not try?

Remove the function get and all of the garbage that was involved in making it exist, including the previous table and all of that stuff.