xlab-uiuc / idoct Goto Github PK

Hi,
I was trying to follow the instructions available at https://docs.google.com/document/d/12zoCmQViY3MOvRCqf0aBXikj_A1zh3Lq48vZttayPhw/
and setup the IDoCT repository.
When running the TestCryptoStreams test, I am getting the following build error:

[INFO] ------------------------------------------------------------------------                                                                              
[INFO] BUILD FAILURE                                                                                                                                         
[INFO] ------------------------------------------------------------------------                                                                              
[INFO] Total time:  03:04 min                                                                                                                                
[INFO] Finished at: 2022-12-04T16:26:42-06:00                                                                                                                
[INFO] ------------------------------------------------------------------------                                                                              
[ERROR] Failed to execute goal on project hadoop-yarn-applications-catalog-webapp: Could not resolve dependencies for project org.apache.hadoop:hadoop-yarn-a
pplications-catalog-webapp:war:3.3.1: Failed to collect dependencies at org.apache.solr:solr-core:jar:7.7.0 -> org.restlet.jee:org.restlet:jar:2.3.0: Failed 
to read artifact descriptor for org.restlet.jee:org.restlet:jar:2.3.0: Could not transfer artifact org.restlet.jee:org.restlet:pom:2.3.0 from/to maven-defaul
t-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [maven-restlet (http://maven.restlet.org, default, releases+snapshots), apache.snapshots (
http://repository.apache.org/snapshots, default, disabled)] -> [Help 1]                                                                                      
[ERROR]                                                                                                                                                      
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.                                                                          
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :hadoop-yarn-applications-catalog-webapp

I tried to look it up and came across the following bug - https://issues.apache.org/jira/browse/HADOOP-17650 which was resolved in the April update. The commit that I am working of of is the one suggested in the document and is after this fix.

commit a3b9c37a397ad4188041dd80621bdeefc46885f2 (HEAD, tag: release-3.3.1-RC3, tag: rel/release-3.3.1, origin/branch-3.3.1)
Author: Wei-Chiu Chuang <[email protected]>
Date:   Tue Jun 1 16:37:28 2021 +0800

Any suggestions on what might be going wrong?

Here are the related version info:

Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Java version: 18.0.1, vendor: Homebrew, runtime: /usr/local/Cellar/openjdk/18.0.1/libexec/openjdk.jdk/Contents/Home
OS name: "mac os x", version: "13.0", arch: "x86_64", family: "mac"

Hi,
I was trying to understand the existing re-written ctests and see if my understanding of ctests is correct or not.
I see that there are ctest rewrites for tests like:

1. https://github.com/xlab-uiuc/IDoCT/blob/main/hadoop/test_rewrite/org.apache.hadoop.ipc.TestIdentityProviders.patch
2. https://github.com/xlab-uiuc/IDoCT/blob/main/hadoop/test_rewrite/org.apache.hadoop.crypto.key.kms.TestLoadBalancingKMSClientProvider.patch

But, for these test names, I do not see any entry in ctest_metadata file. The same tests also do not have an entry in the mapping file. Does that mean they do not exercise any configuration parameters? And if so, then why are ctests re-written for these?

Also, in terms of ctest_metadata, although the number of overall tests are in the order of ~2.5k, the number of unique tests in ctest_metadata are only limited to 19. Is it mostly that ctests haven't been ported for other tests or is there any other reason/limitation? This would help in shortlisting the tests for which I can implement the ctests?

For parameters logged in *-output.txt files with "LOG.WARN", I noticed that they will be overwritten by each test method in the same test class while running the script to identify those parameters, and all test methods have an identical parameter list in the same test class.

Is that how this project is designed to behave? What if a single test method only exercises a subset of those parameters?

As mentioned in the Pull Request #27, there is an inconsistency between the description of the onboarding task and the CI scripts
Currently, the onboarding task instructs students to randomly select five tests, while the CI scripts generate an error if the chosen tests have already been selected by other students.

To address this issue, we can implement the following solutions:

1. Update the onboarding task: Modify the instructions to ask students to select only untouched tests, i.e., tests that have not been chosen by any other student.
2. Update the CI scripts: Instead of throwing an error when duplicate tests are detected, change the behavior to issue a warning. This will allow the CI process to proceed without blocking the execution, but still notify users about the potential issue of duplicate test selection.

@Alex-Lian I have a question about OpenCtest and IDoCT.

How are they related? It seems to me that it is odd that we are keeping two separate copies of the same repo? Is there a way to merge these two repos (e.g., OpenCtest as a git submodule as IDoCT)?

Hi, I ran the run_ctest.py script with two parameters (the second parameter value is only considered when the first parameter is true). How do I report such cases with GOOD|PASS or BAD|FAIL within ctest_metadata.csv?

replace "random tests" with instructions to select tests that haven't been converted in IDoCT